* [PATCH v1] xen/pci: Use acpi_noirq_set() helper
@ 2017-07-17 10:39 Andy Shevchenko
2017-08-02 21:45 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2017-07-17 10:39 UTC (permalink / raw)
To: Bjorn Helgaas, linux-pci, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, Konrad Rzeszutek Wilk, Rafael J . Wysocki
Cc: Andy Shevchenko
No need to keep an #ifdef since we have a helper (in x86 world).
Use it instead.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/pci/xen.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index c4b3646bd04c..9542a746dc50 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -409,10 +409,8 @@ int __init pci_xen_init(void)
pcibios_enable_irq = xen_pcifront_enable_irq;
pcibios_disable_irq = NULL;
-#ifdef CONFIG_ACPI
/* Keep ACPI out of the picture */
- acpi_noirq = 1;
-#endif
+ acpi_noirq_set();
#ifdef CONFIG_PCI_MSI
x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] xen/pci: Use acpi_noirq_set() helper
2017-07-17 10:39 [PATCH v1] xen/pci: Use acpi_noirq_set() helper Andy Shevchenko
@ 2017-08-02 21:45 ` Bjorn Helgaas
2017-08-10 9:19 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2017-08-02 21:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bjorn Helgaas, linux-pci, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, Konrad Rzeszutek Wilk, Rafael J . Wysocki
On Mon, Jul 17, 2017 at 01:39:07PM +0300, Andy Shevchenko wrote:
> No need to keep an #ifdef since we have a helper (in x86 world).
> Use it instead.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks reasonable to me, and I assume some non-PCI tree will take it.
> ---
> arch/x86/pci/xen.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index c4b3646bd04c..9542a746dc50 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -409,10 +409,8 @@ int __init pci_xen_init(void)
> pcibios_enable_irq = xen_pcifront_enable_irq;
> pcibios_disable_irq = NULL;
>
> -#ifdef CONFIG_ACPI
> /* Keep ACPI out of the picture */
> - acpi_noirq = 1;
> -#endif
> + acpi_noirq_set();
>
> #ifdef CONFIG_PCI_MSI
> x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] xen/pci: Use acpi_noirq_set() helper
2017-08-02 21:45 ` Bjorn Helgaas
@ 2017-08-10 9:19 ` Andy Shevchenko
2017-08-29 13:52 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2017-08-10 9:19 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Bjorn Helgaas, linux-pci, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, Konrad Rzeszutek Wilk, Rafael J . Wysocki
On Wed, 2017-08-02 at 16:45 -0500, Bjorn Helgaas wrote:
> On Mon, Jul 17, 2017 at 01:39:07PM +0300, Andy Shevchenko wrote:
> > No need to keep an #ifdef since we have a helper (in x86 world).
> > Use it instead.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Looks reasonable to me, and I assume some non-PCI tree will take it.
It seems either TODO list is long, or everyone from x86 is on vacation
:-)
Can't you push this through your tree?
>
> > ---
> > arch/x86/pci/xen.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> > index c4b3646bd04c..9542a746dc50 100644
> > --- a/arch/x86/pci/xen.c
> > +++ b/arch/x86/pci/xen.c
> > @@ -409,10 +409,8 @@ int __init pci_xen_init(void)
> > pcibios_enable_irq = xen_pcifront_enable_irq;
> > pcibios_disable_irq = NULL;
> >
> > -#ifdef CONFIG_ACPI
> > /* Keep ACPI out of the picture */
> > - acpi_noirq = 1;
> > -#endif
> > + acpi_noirq_set();
> >
> > #ifdef CONFIG_PCI_MSI
> > x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
> > --
> > 2.11.0
> >
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] xen/pci: Use acpi_noirq_set() helper
2017-08-10 9:19 ` Andy Shevchenko
@ 2017-08-29 13:52 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2017-08-29 13:52 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Bjorn Helgaas, linux-pci, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, Konrad Rzeszutek Wilk, Rafael J . Wysocki
On Thu, 2017-08-10 at 12:19 +0300, Andy Shevchenko wrote:
> On Wed, 2017-08-02 at 16:45 -0500, Bjorn Helgaas wrote:
> > On Mon, Jul 17, 2017 at 01:39:07PM +0300, Andy Shevchenko wrote:
> > > No need to keep an #ifdef since we have a helper (in x86 world).
> > > Use it instead.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Looks reasonable to me, and I assume some non-PCI tree will take it.
>
> It seems either TODO list is long, or everyone from x86 is on vacation
> :-)
>
> Can't you push this through your tree?
It might be lost in pile of mails, a gentle up.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-29 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-17 10:39 [PATCH v1] xen/pci: Use acpi_noirq_set() helper Andy Shevchenko
2017-08-02 21:45 ` Bjorn Helgaas
2017-08-10 9:19 ` Andy Shevchenko
2017-08-29 13:52 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).