From: Fabio Estevam <festevam@gmail.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>
Subject: [PATCH 3/5] PCI: mediatek: Check for platform_get_irq() error
Date: Sat, 14 Oct 2017 19:07:29 -0300 [thread overview]
Message-ID: <1508018851-9272-3-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1508018851-9272-1-git-send-email-festevam@gmail.com>
platform_get_irq() may fail and in the case of failure the error value
should be propagated.
Cc: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/pci/host/pcie-mediatek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
index db93efd..05f8c33 100644
--- a/drivers/pci/host/pcie-mediatek.c
+++ b/drivers/pci/host/pcie-mediatek.c
@@ -642,6 +642,8 @@ static int mtk_pcie_setup_irq(struct mtk_pcie_port *port,
int err, irq;
irq = platform_get_irq(pdev, port->slot);
+ if (irq < 0)
+ return irq;
err = devm_request_irq(dev, irq, mtk_pcie_intr_handler,
IRQF_SHARED, "mtk-pcie", port);
if (err) {
--
2.7.4
next prev parent reply other threads:[~2017-10-14 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 22:07 [PATCH 1/5] PCI: aardvark: Check for platform_get_irq() error Fabio Estevam
2017-10-14 22:07 ` [PATCH 2/5] PCI: v3-semi: Fix platform_get_irq() error handling Fabio Estevam
2017-10-14 22:26 ` Linus Walleij
2017-10-14 22:07 ` Fabio Estevam [this message]
2017-10-14 22:07 ` [PATCH 4/5] PCI: tango: " Fabio Estevam
2017-10-16 9:09 ` Marc Gonzalez
2017-10-16 9:19 ` Linus Walleij
2017-10-20 22:31 ` Bjorn Helgaas
2017-10-26 6:37 ` Mason
2017-10-14 22:07 ` [PATCH 5/5] PCI: xilinx-nwl: " Fabio Estevam
2017-10-17 8:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508018851-9272-3-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).