From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: <thierry.reding@gmail.com>, <bhelgaas@google.com>,
<jonathanh@nvidia.com>, <vidyas@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<kthota@nvidia.com>,
Manikanta Maddireddy <mmaddireddy@nvidia.com>
Subject: [PATCH V2 06/12] PCI: tegra: Enable opportunistic update FC and ACK
Date: Mon, 30 Oct 2017 09:48:57 +0530 [thread overview]
Message-ID: <1509337143-25963-7-git-send-email-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <1509337143-25963-1-git-send-email-mmaddireddy@nvidia.com>
This patch ensures that DL sends pending ACKs and update FC packets when
link is idle instead of waiting for timers to expire which improves PCIe
bandwidth.
Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
---
V2:
* no change in this patch
drivers/pci/host/pci-tegra.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 51b7821646eb..bf615c5e6b78 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -209,7 +209,9 @@
#define RP_ECTL_6_R2_RX_EQ_CTRL_H_1C_MASK 0xffffffff
#define RP_VEND_XP 0x00000f00
-#define RP_VEND_XP_DL_UP (1 << 30)
+#define RP_VEND_XP_DL_UP (1 << 30)
+#define RP_VEND_XP_OPPORTUNISTIC_ACK (1 << 27)
+#define RP_VEND_XP_OPPORTUNISTIC_UPDATEFC (1 << 28)
#define RP_VEND_CTL1 0xf48
#define RP_VEND_CTL1_ERPT (1 << 13)
@@ -2147,6 +2149,16 @@ static void tegra_pcie_enable_rp_features(struct tegra_pcie_port *port)
writel(value, port->base + RP_VEND_CTL1);
}
+static void tegra_pcie_apply_sw_fixup(struct tegra_pcie_port *port)
+{
+ unsigned long value;
+
+ /* Optimal settings to enhance bandwidth */
+ value = readl(port->base + RP_VEND_XP);
+ value |= RP_VEND_XP_OPPORTUNISTIC_ACK;
+ value |= RP_VEND_XP_OPPORTUNISTIC_UPDATEFC;
+ writel(value, port->base + RP_VEND_XP);
+}
/*
* FIXME: If there are no PCIe cards attached, then calling this function
* can result in the increase of the bootup time as there are big timeout
@@ -2215,6 +2227,7 @@ static void tegra_pcie_enable_ports(struct tegra_pcie *pcie)
if (soc->program_ectl_settings)
tegra_pcie_program_ectl_settings(port);
tegra_pcie_enable_rp_features(port);
+ tegra_pcie_apply_sw_fixup(port);
}
/* take the PCIe interface module out of reset */
--
2.1.4
next prev parent reply other threads:[~2017-10-30 4:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 4:18 [PATCH V2 00/12] Enable Tegra root port features and apply SW fixups Manikanta Maddireddy
2017-10-30 4:18 ` [PATCH V2 01/12] PCI: tegra: Start LTSSM after programming root port Manikanta Maddireddy
2017-10-30 9:08 ` Mikko Perttunen
2017-10-30 10:36 ` Manikanta Maddireddy
2017-10-30 4:18 ` [PATCH V2 02/12] PCI: tegra: Move REFCLK pad settings out of phy_power_on() Manikanta Maddireddy
2017-10-30 9:13 ` Mikko Perttunen
2017-10-30 4:18 ` [PATCH V2 03/12] PCI: tegra: Retrain link for Gen2 speed Manikanta Maddireddy
2017-10-30 9:31 ` Mikko Perttunen
2017-10-30 4:18 ` [PATCH V2 04/12] PCI: tegra: Advertise AER capability Manikanta Maddireddy
2017-10-30 9:36 ` Mikko Perttunen
2017-10-30 11:49 ` Manikanta Maddireddy
2017-10-30 4:18 ` [PATCH V2 05/12] PCI: tegra: Program UPHY electrical settings in Tegra210 Manikanta Maddireddy
2017-10-30 9:56 ` Mikko Perttunen
2017-10-30 4:18 ` Manikanta Maddireddy [this message]
2017-10-30 9:58 ` [PATCH V2 06/12] PCI: tegra: Enable opportunistic update FC and ACK Mikko Perttunen
2017-10-30 4:18 ` [PATCH V2 07/12] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy
2017-10-30 10:00 ` Mikko Perttunen
2017-10-30 4:18 ` [PATCH V2 08/12] PCI: tegra: Wait for DLLP to finish before entering L1 or L2 Manikanta Maddireddy
2017-10-30 10:02 ` Mikko Perttunen
2017-10-30 4:19 ` [PATCH V2 09/12] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy
2017-10-30 10:06 ` Mikko Perttunen
2017-10-30 12:03 ` Manikanta Maddireddy
2017-10-30 4:19 ` [PATCH V2 10/12] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy
2017-10-30 10:09 ` Mikko Perttunen
2017-10-30 4:19 ` [PATCH V2 11/12] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy
2017-10-30 10:10 ` Mikko Perttunen
2017-10-30 4:19 ` [PATCH V2 12/12] PCI: tegra: Update flow control threshold in Tegra210 Manikanta Maddireddy
2017-10-30 10:11 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509337143-25963-7-git-send-email-mmaddireddy@nvidia.com \
--to=mmaddireddy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).