linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: linux-arm-kernel@lists.infradead.org,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<dri-devel@lists.freedesktop.org>,
	Sinan Kaya <okaya@codeaurora.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	Ilia Mirkin <imirkin@alum.mit.edu>
Subject: [PATCH 10/30] drm/nouveau: deprecate pci_get_bus_and_slot()
Date: Wed, 22 Nov 2017 00:30:55 -0500	[thread overview]
Message-ID: <1511328675-21981-11-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1511328675-21981-1-git-send-email-okaya@codeaurora.org>

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.

Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't
extract the domain number. Other places, use the actual domain number from
the device.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/gpu/drm/nouveau/dispnv04/arb.c           | 3 ++-
 drivers/gpu/drm/nouveau/dispnv04/hw.c            | 6 ++++--
 drivers/gpu/drm/nouveau/nouveau_drm.c            | 3 ++-
 drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c | 2 +-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv04/arb.c b/drivers/gpu/drm/nouveau/dispnv04/arb.c
index 90075b6..729d7d0 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/arb.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/arb.c
@@ -214,7 +214,8 @@ struct nv_sim_state {
 	    (dev->pdev->device & 0xffff) == 0x01f0 /*CHIPSET_NFORCE2*/) {
 		uint32_t type;
 
-		pci_read_config_dword(pci_get_bus_and_slot(0, 1), 0x7c, &type);
+		pci_read_config_dword(pci_get_domain_bus_and_slot(0, 0, 1),
+				      0x7c, &type);
 
 		sim_data.memory_type = (type >> 12) & 1;
 		sim_data.memory_width = 64;
diff --git a/drivers/gpu/drm/nouveau/dispnv04/hw.c b/drivers/gpu/drm/nouveau/dispnv04/hw.c
index b985990..4b35093 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/hw.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/hw.c
@@ -221,7 +221,8 @@
 	    (dev->pdev->device & 0x0ff0) == CHIPSET_NFORCE) {
 		uint32_t mpllP;
 
-		pci_read_config_dword(pci_get_bus_and_slot(0, 3), 0x6c, &mpllP);
+		pci_read_config_dword(pci_get_domain_bus_and_slot(0, 0, 3),
+				      0x6c, &mpllP);
 		mpllP = (mpllP >> 8) & 0xf;
 		if (!mpllP)
 			mpllP = 4;
@@ -232,7 +233,8 @@
 	    (dev->pdev->device & 0xff0) == CHIPSET_NFORCE2) {
 		uint32_t clock;
 
-		pci_read_config_dword(pci_get_bus_and_slot(0, 5), 0x4c, &clock);
+		pci_read_config_dword(pci_get_domain_bus_and_slot(0, 0, 5),
+				      0x4c, &clock);
 		return clock / 1000;
 	}
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 595630d..0b6c639 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -406,7 +406,8 @@ static int nouveau_drm_probe(struct pci_dev *pdev,
 	}
 
 	/* subfunction one is a hdmi audio device? */
-	drm->hdmi_device = pci_get_bus_and_slot((unsigned int)pdev->bus->number,
+	drm->hdmi_device = pci_get_domain_bus_and_slot(pci_domain_nr(pdev->bus),
+						(unsigned int)pdev->bus->number,
 						PCI_DEVFN(PCI_SLOT(pdev->devfn), 1));
 
 	if (!drm->hdmi_device) {
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c
index 3c6a871..3d2a203 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c
@@ -29,7 +29,7 @@
 	struct pci_dev *bridge;
 	u32 mem, mib;
 
-	bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 1));
+	bridge = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 1));
 	if (!bridge) {
 		nvkm_error(&fb->subdev, "no bridge device\n");
 		return -ENODEV;
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2017-11-22  5:30 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22  5:30 [PATCH 00/30] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22  5:30 ` [PATCH 01/30] alpha/PCI: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 02/30] powerpc/PCI: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 03/30] x86/PCI: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 04/30] ata: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 05/30] agp: nvidia: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 06/30] edd: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 07/30] ibft: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 08/30] drm/gma500: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 09/30] drm/i915: " Sinan Kaya
2017-11-22  7:52   ` Joonas Lahtinen
2017-11-22 16:28     ` Sinan Kaya
2017-11-22 19:50       ` Jani Nikula
2017-11-22 19:58         ` Timur Tabi
2017-11-23  7:14           ` Jani Nikula
2017-11-23  7:42       ` Joonas Lahtinen
2017-11-23 18:37         ` Sinan Kaya
2017-11-27  8:56           ` Joonas Lahtinen
2017-11-27 14:05             ` Sinan Kaya
2017-11-22  5:30 ` Sinan Kaya [this message]
2017-11-22  5:30 ` [PATCH 11/30] hwmon: (coretemp) " Sinan Kaya
2017-11-22 15:07   ` [11/30] " Guenter Roeck
2017-11-22  5:30 ` [PATCH 12/30] Drivers: ide: " Sinan Kaya
2017-11-22  7:53   ` Greg KH
2017-11-22 16:24     ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 13/30] iommu/amd: " Sinan Kaya
2017-11-22  5:30 ` [PATCH 14/30] powerpc/powermac: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 15/30] bnx2x: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 16/30] pch_gbe: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 17/30] PCI: cpqhp: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 18/30] PCI: ibmphp: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 19/30] PCI/quirks: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 20/30] PCI/syscall: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 21/30] xen: " Sinan Kaya
2017-11-22 12:53   ` Juergen Gross
2017-11-22  5:31 ` [PATCH 22/30] openprom: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 23/30] [media] atomisp: " Sinan Kaya
2017-11-22 12:20   ` Alan Cox
2017-11-22 14:05     ` Sinan Kaya
2017-11-22 14:06       ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 24/30] staging: rts5208: " Sinan Kaya
2017-11-22  7:54   ` Greg Kroah-Hartman
2017-11-22  5:31 ` [PATCH 25/30] backlight: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 26/30] video: fbdev: intelfb: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 27/30] video: fbdev: nvidia: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 28/30] video: fbdev: riva: " Sinan Kaya
2017-11-22  5:31 ` [PATCH 29/30] i7300_idle: " Sinan Kaya
2017-11-22  7:53   ` Greg Kroah-Hartman
2017-11-22 16:15     ` Sinan Kaya
2017-11-22 16:45       ` Greg Kroah-Hartman
2017-11-22 16:50         ` Sinan Kaya
2017-11-22 16:58           ` Greg Kroah-Hartman
2017-11-22  5:31 ` [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function Sinan Kaya
2017-11-22  5:45   ` Timur Tabi
2017-11-22  5:55     ` Sinan Kaya
2017-11-22  6:08       ` Timur Tabi
2017-11-22  7:51         ` Greg KH
2017-11-22 14:42           ` Timur Tabi
2017-11-22 14:49             ` Greg KH
2017-11-22 15:18               ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511328675-21981-11-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imirkin@alum.mit.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).