linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>, Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org (open list:AMD IOMMU (AMD-VI)),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V2 12/29] iommu/amd: deprecate pci_get_bus_and_slot()
Date: Wed, 22 Nov 2017 17:49:07 -0500	[thread overview]
Message-ID: <1511390964-9979-13-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1511390964-9979-1-git-send-email-okaya@codeaurora.org>

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.

Getting ready to remove pci_get_bus_and_slot() function in favor of
pci_get_domain_bus_and_slot().

Hard-code the domain number as 0 for the AMD IOMMU driver.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/iommu/amd_iommu.c      | 3 ++-
 drivers/iommu/amd_iommu_init.c | 9 +++++----
 drivers/iommu/amd_iommu_v2.c   | 3 ++-
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 8e8874d..2c3452f 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -528,7 +528,8 @@ static void amd_iommu_report_page_fault(u16 devid, u16 domain_id,
 	struct iommu_dev_data *dev_data = NULL;
 	struct pci_dev *pdev;
 
-	pdev = pci_get_bus_and_slot(PCI_BUS_NUM(devid), devid & 0xff);
+	pdev = pci_get_domain_bus_and_slot(0, PCI_BUS_NUM(devid),
+					   devid & 0xff);
 	if (pdev)
 		dev_data = get_dev_data(&pdev->dev);
 
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 6fe2d03..4e4a615 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1697,8 +1697,8 @@ static int iommu_init_pci(struct amd_iommu *iommu)
 	u32 range, misc, low, high;
 	int ret;
 
-	iommu->dev = pci_get_bus_and_slot(PCI_BUS_NUM(iommu->devid),
-					  iommu->devid & 0xff);
+	iommu->dev = pci_get_domain_bus_and_slot(0, PCI_BUS_NUM(iommu->devid),
+						 iommu->devid & 0xff);
 	if (!iommu->dev)
 		return -ENODEV;
 
@@ -1764,8 +1764,9 @@ static int iommu_init_pci(struct amd_iommu *iommu)
 	if (is_rd890_iommu(iommu->dev)) {
 		int i, j;
 
-		iommu->root_pdev = pci_get_bus_and_slot(iommu->dev->bus->number,
-				PCI_DEVFN(0, 0));
+		iommu->root_pdev =
+			pci_get_domain_bus_and_slot(0, iommu->dev->bus->number,
+						    PCI_DEVFN(0, 0));
 
 		/*
 		 * Some rd890 systems may not be fully reconfigured by the
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
index 7d94e1d..8696382 100644
--- a/drivers/iommu/amd_iommu_v2.c
+++ b/drivers/iommu/amd_iommu_v2.c
@@ -564,7 +564,8 @@ static int ppr_notifier(struct notifier_block *nb, unsigned long e, void *data)
 	finish      = (iommu_fault->tag >> 9) & 1;
 
 	devid = iommu_fault->device_id;
-	pdev = pci_get_bus_and_slot(PCI_BUS_NUM(devid), devid & 0xff);
+	pdev = pci_get_domain_bus_and_slot(0, PCI_BUS_NUM(devid),
+					   devid & 0xff);
 	if (!pdev)
 		return -ENODEV;
 	dev_data = get_dev_data(&pdev->dev);
-- 
1.9.1

  parent reply	other threads:[~2017-11-22 22:50 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 22:48 [PATCH V2 00/29] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 01/29] alpha/PCI: " Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 02/29] powerpc/PCI: " Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 03/29] x86/PCI: " Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 04/29] ata: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 05/29] agp: nvidia: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 06/29] edd: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 07/29] ibft: " Sinan Kaya
2017-11-24 13:29   ` Konrad Rzeszutek Wilk
2017-11-22 22:49 ` [PATCH V2 08/29] drm/gma500: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 09/29] drm/i915: " Sinan Kaya
2017-11-22 23:25   ` Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 10/29] drm/nouveau: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 11/29] Drivers: ide: " Sinan Kaya
2017-11-22 22:49 ` Sinan Kaya [this message]
2017-11-22 22:49 ` [PATCH V2 13/29] powerpc/powermac: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 14/29] bnx2x: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 15/29] pch_gbe: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 16/29] PCI: cpqhp: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 17/29] PCI: ibmphp: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 18/29] PCI/quirks: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 19/29] PCI/syscall: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 20/29] xen: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 21/29] openprom: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 22/29] [media] atomisp: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 23/29] staging: rts5208: " Sinan Kaya
2017-11-24 14:58   ` Greg Kroah-Hartman
2017-11-22 22:49 ` [PATCH V2 24/29] backlight: " Sinan Kaya
2017-11-23 12:11   ` Daniel Thompson
2017-11-22 22:49 ` [PATCH V2 25/29] video: fbdev: intelfb: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 26/29] video: fbdev: nvidia: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 27/29] video: fbdev: riva: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 28/29] i7300_idle: remove unused file Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 29/29] PCI: remove pci_get_bus_and_slot() function Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511390964-9979-13-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).