linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V2 16/29] PCI: cpqhp: deprecate pci_get_bus_and_slot()
Date: Wed, 22 Nov 2017 17:49:11 -0500	[thread overview]
Message-ID: <1511390964-9979-17-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1511390964-9979-1-git-send-email-okaya@codeaurora.org>

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.

Getting ready to remove pci_get_bus_and_slot() function in favor of
pci_get_domain_bus_and_slot().

Hard-coding the domain number as 0. The code doesn't seem to be ready
for multiple domains.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/hotplug/cpqphp_pci.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/hotplug/cpqphp_pci.c b/drivers/pci/hotplug/cpqphp_pci.c
index e220d49..8897a77 100644
--- a/drivers/pci/hotplug/cpqphp_pci.c
+++ b/drivers/pci/hotplug/cpqphp_pci.c
@@ -89,7 +89,9 @@ int cpqhp_configure_device(struct controller *ctrl, struct pci_func *func)
 	pci_lock_rescan_remove();
 
 	if (func->pci_dev == NULL)
-		func->pci_dev = pci_get_bus_and_slot(func->bus, PCI_DEVFN(func->device, func->function));
+		func->pci_dev = pci_get_domain_bus_and_slot(0, func->bus,
+							PCI_DEVFN(func->device,
+							func->function));
 
 	/* No pci device, we need to create it then */
 	if (func->pci_dev == NULL) {
@@ -99,7 +101,9 @@ int cpqhp_configure_device(struct controller *ctrl, struct pci_func *func)
 		if (num)
 			pci_bus_add_devices(ctrl->pci_dev->bus);
 
-		func->pci_dev = pci_get_bus_and_slot(func->bus, PCI_DEVFN(func->device, func->function));
+		func->pci_dev = pci_get_domain_bus_and_slot(0, func->bus,
+							PCI_DEVFN(func->device,
+							func->function));
 		if (func->pci_dev == NULL) {
 			dbg("ERROR: pci_dev still null\n");
 			goto out;
@@ -129,7 +133,10 @@ int cpqhp_unconfigure_device(struct pci_func *func)
 
 	pci_lock_rescan_remove();
 	for (j = 0; j < 8 ; j++) {
-		struct pci_dev *temp = pci_get_bus_and_slot(func->bus, PCI_DEVFN(func->device, j));
+		struct pci_dev *temp = pci_get_domain_bus_and_slot(0,
+							func->bus,
+							PCI_DEVFN(func->device,
+							j));
 		if (temp) {
 			pci_dev_put(temp);
 			pci_stop_and_remove_bus_device(temp);
@@ -319,6 +326,7 @@ int cpqhp_save_config(struct controller *ctrl, int busnumber, int is_hot_plug)
 	int cloop = 0;
 	int stop_it;
 	int index;
+	u16 devfn;
 
 	/* Decide which slots are supported */
 
@@ -416,7 +424,9 @@ int cpqhp_save_config(struct controller *ctrl, int busnumber, int is_hot_plug)
 			new_slot->switch_save = 0x10;
 			/* In case of unsupported board */
 			new_slot->status = DevError;
-			new_slot->pci_dev = pci_get_bus_and_slot(new_slot->bus, (new_slot->device << 3) | new_slot->function);
+			devfn = (new_slot->device << 3) | new_slot->function;
+			new_slot->pci_dev = pci_get_domain_bus_and_slot(0,
+							new_slot->bus, devfn);
 
 			for (cloop = 0; cloop < 0x20; cloop++) {
 				rc = pci_bus_read_config_dword(ctrl->pci_bus, PCI_DEVFN(device, function), cloop << 2, (u32 *) &(new_slot->config_space[cloop]));
-- 
1.9.1

  parent reply	other threads:[~2017-11-22 22:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 22:48 [PATCH V2 00/29] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 01/29] alpha/PCI: " Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 02/29] powerpc/PCI: " Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 03/29] x86/PCI: " Sinan Kaya
2017-11-22 22:48 ` [PATCH V2 04/29] ata: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 05/29] agp: nvidia: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 06/29] edd: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 07/29] ibft: " Sinan Kaya
2017-11-24 13:29   ` Konrad Rzeszutek Wilk
2017-11-22 22:49 ` [PATCH V2 08/29] drm/gma500: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 09/29] drm/i915: " Sinan Kaya
2017-11-22 23:25   ` Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 10/29] drm/nouveau: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 11/29] Drivers: ide: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 12/29] iommu/amd: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 13/29] powerpc/powermac: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 14/29] bnx2x: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 15/29] pch_gbe: " Sinan Kaya
2017-11-22 22:49 ` Sinan Kaya [this message]
2017-11-22 22:49 ` [PATCH V2 17/29] PCI: ibmphp: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 18/29] PCI/quirks: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 19/29] PCI/syscall: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 20/29] xen: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 21/29] openprom: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 22/29] [media] atomisp: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 23/29] staging: rts5208: " Sinan Kaya
2017-11-24 14:58   ` Greg Kroah-Hartman
2017-11-22 22:49 ` [PATCH V2 24/29] backlight: " Sinan Kaya
2017-11-23 12:11   ` Daniel Thompson
2017-11-22 22:49 ` [PATCH V2 25/29] video: fbdev: intelfb: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 26/29] video: fbdev: nvidia: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 27/29] video: fbdev: riva: " Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 28/29] i7300_idle: remove unused file Sinan Kaya
2017-11-22 22:49 ` [PATCH V2 29/29] PCI: remove pci_get_bus_and_slot() function Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511390964-9979-17-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).