From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:6889 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbdK0I5P (ORCPT ); Mon, 27 Nov 2017 03:57:15 -0500 Message-ID: <1511773014.4627.14.camel@linux.intel.com> Subject: Re: [PATCH 09/30] drm/i915: deprecate pci_get_bus_and_slot() From: Joonas Lahtinen To: Sinan Kaya , linux-pci@vger.kernel.org, timur@codeaurora.org Cc: Jani Nikula , Rodrigo Vivi Date: Mon, 27 Nov 2017 10:56:54 +0200 In-Reply-To: <0b12dcfe-1ee1-10ef-4db3-9c9d42dc4703@codeaurora.org> References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-10-git-send-email-okaya@codeaurora.org> <1511337146.4512.6.camel@linux.intel.com> <4541eaef-745a-e78f-e61d-1c7c207b551e@codeaurora.org> <1511422959.4641.5.camel@linux.intel.com> <0b12dcfe-1ee1-10ef-4db3-9c9d42dc4703@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, 2017-11-23 at 13:37 -0500, Sinan Kaya wrote: > On 11/23/2017 2:42 AM, Joonas Lahtinen wrote: > > It is not longer than 80 characters when you break line before the > > PCI_DEVFN like I proposed. Or you can break it after the "=", too, > > either way works fine. > > I posted V2 with this suggestion. > > https://patchwork.kernel.org/patch/10071759/ > > Let me know what you think about the domain number call here. > > u32 domain = pci_domain_nr(dev_priv->drm.pdev->bus); The function return signature is 'int' as well as the parameter in pci_get_domain_bus_and_slot is type 'int', so why fight it and try to make the variable 'u32'? > I don't have a way to test this change. I traced the drm_device's pdev > assignment in the code. It should work fine but I don't have a proof. Send the patch to intel-gfx@lists.freedesktop.org and it should get automatically tested by our CI system. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation