From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
intel-gfx@lists.freedesktop.org,
Sinan Kaya <okaya@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V3 17/29] PCI: ibmphp: deprecate pci_get_bus_and_slot()
Date: Mon, 27 Nov 2017 11:57:54 -0500 [thread overview]
Message-ID: <1511801886-6753-18-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1511801886-6753-1-git-send-email-okaya@codeaurora.org>
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.
Getting ready to remove pci_get_bus_and_slot() function in favor of
pci_get_domain_bus_and_slot().
Hard-coding the domain parameter as 0 since the code doesn't seem to be
ready for multiple domains.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/pci/hotplug/ibmphp_core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index 73cf846..92dd882 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -707,7 +707,8 @@ static void ibm_unconfigure_device(struct pci_func *func)
pci_lock_rescan_remove();
for (j = 0; j < 0x08; j++) {
- temp = pci_get_bus_and_slot(func->busno, (func->device << 3) | j);
+ temp = pci_get_domain_bus_and_slot(0, func->busno,
+ (func->device << 3) | j);
if (temp) {
pci_stop_and_remove_bus_device(temp);
pci_dev_put(temp);
@@ -780,7 +781,7 @@ static int ibm_configure_device(struct pci_func *func)
if (!(bus_structure_fixup(func->busno)))
flag = 1;
if (func->dev == NULL)
- func->dev = pci_get_bus_and_slot(func->busno,
+ func->dev = pci_get_domain_bus_and_slot(0, func->busno,
PCI_DEVFN(func->device, func->function));
if (func->dev == NULL) {
@@ -793,7 +794,7 @@ static int ibm_configure_device(struct pci_func *func)
if (num)
pci_bus_add_devices(bus);
- func->dev = pci_get_bus_and_slot(func->busno,
+ func->dev = pci_get_domain_bus_and_slot(0, func->busno,
PCI_DEVFN(func->device, func->function));
if (func->dev == NULL) {
err("ERROR... : pci_dev still NULL\n");
--
1.9.1
next prev parent reply other threads:[~2017-11-27 16:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 16:57 [PATCH V3 00/29] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 01/29] alpha/PCI: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 02/29] powerpc/PCI: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 03/29] x86/PCI: " Sinan Kaya
2017-11-28 13:45 ` Thomas Gleixner
2017-11-27 16:57 ` [PATCH V3 04/29] ata: " Sinan Kaya
2017-11-27 19:50 ` Tejun Heo
2017-11-27 16:57 ` [PATCH V3 05/29] agp: nvidia: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 06/29] edd: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 07/29] ibft: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 08/29] drm/gma500: " Sinan Kaya
2017-11-27 18:49 ` Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 09/29] drm/i915: " Sinan Kaya
2017-11-27 18:50 ` Sinan Kaya
2017-12-12 14:04 ` Joonas Lahtinen
2017-12-13 0:07 ` Sinan Kaya
2017-12-13 8:01 ` Joonas Lahtinen
2017-11-28 15:30 ` [Intel-gfx] " Ville Syrjälä
2017-11-28 16:29 ` Sinan Kaya
2017-12-03 19:29 ` Sinan Kaya
2018-02-16 14:54 ` Bjorn Helgaas
2018-02-19 9:34 ` Jani Nikula
2018-02-19 9:47 ` Joonas Lahtinen
2017-11-27 16:57 ` [PATCH V3 10/29] drm/nouveau: " Sinan Kaya
2017-11-27 18:52 ` Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 11/29] Drivers: ide: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 12/29] iommu/amd: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 13/29] powerpc/powermac: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 14/29] bnx2x: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 15/29] pch_gbe: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 16/29] PCI: cpqhp: " Sinan Kaya
2017-11-27 16:57 ` Sinan Kaya [this message]
2017-11-27 16:57 ` [PATCH V3 18/29] PCI/quirks: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 19/29] PCI/syscall: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 20/29] xen: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 21/29] openprom: " Sinan Kaya
2017-11-27 16:57 ` [PATCH V3 22/29] [media] atomisp: " Sinan Kaya
2017-11-29 8:36 ` Sakari Ailus
2017-11-27 16:58 ` [PATCH V3 23/29] staging: rts5208: remove rtsx_read_pci_cfg_byte() Sinan Kaya
2017-11-27 16:58 ` [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-27 19:46 ` Jingoo Han
2017-11-28 8:13 ` Lee Jones
2017-11-27 16:58 ` [PATCH V3 25/29] video: fbdev: intelfb: " Sinan Kaya
2017-11-27 16:58 ` [PATCH V3 26/29] video: fbdev: nvidia: " Sinan Kaya
2017-11-27 16:58 ` [PATCH V3 27/29] video: fbdev: riva: " Sinan Kaya
2017-11-27 16:58 ` [PATCH V3 28/29] i7300_idle: remove unused file Sinan Kaya
2017-11-27 16:58 ` [PATCH V3 29/29] PCI: remove pci_get_bus_and_slot() function Sinan Kaya
2017-11-29 17:09 ` [PATCH V3 00/29] PCI: deprecate pci_get_bus_and_slot() Bjorn Helgaas
2017-12-01 2:15 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511801886-6753-18-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=bhelgaas@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).