From: Loic Poulain <loic.poulain@linaro.org>
To: songxiaowei@hisilicon.com, wangbinghui@hisilicon.com
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
lorenzo.pieralisi@arm.com, Loic Poulain <loic.poulain@linaro.org>
Subject: [PATCH] PCI: kirin: Fix reset gpio name
Date: Tue, 3 Apr 2018 11:19:01 +0200 [thread overview]
Message-ID: <1522747141-8299-1-git-send-email-loic.poulain@linaro.org> (raw)
As documented in the device-tree bindings (pci/kirin-pcie.txt) and
defined in existing device-tree (hi3660.dtsi), the reset gpio name
is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource
which makes the driver probe fail. Fix this.
Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
drivers/pci/dwc/pcie-kirin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index dc3033c..efc317e 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -490,7 +490,7 @@ static int kirin_pcie_probe(struct platform_device *pdev)
return ret;
kirin_pcie->gpio_id_reset = of_get_named_gpio(dev->of_node,
- "reset-gpio", 0);
+ "reset-gpios", 0);
if (kirin_pcie->gpio_id_reset < 0)
return -ENODEV;
--
2.7.4
next reply other threads:[~2018-04-03 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 9:19 Loic Poulain [this message]
2018-04-16 11:34 ` [PATCH] PCI: kirin: Fix reset gpio name Loic Poulain
2018-04-16 11:48 ` 答复: " songxiaowei
2018-04-16 13:48 ` Lorenzo Pieralisi
2018-04-17 1:05 ` 答复: " songxiaowei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522747141-8299-1-git-send-email-loic.poulain@linaro.org \
--to=loic.poulain@linaro.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=songxiaowei@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).