[PATCH] PCI: kirin: Fix reset gpio name

[PATCH] PCI: kirin: Fix reset gpio name

[Loic Poulain]

As documented in the device-tree bindings (pci/kirin-pcie.txt) and
defined in existing device-tree (hi3660.dtsi), the reset gpio name
is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource
which makes the driver probe fail. Fix this.

Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
 drivers/pci/dwc/pcie-kirin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index dc3033c..efc317e 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -490,7 +490,7 @@ static int kirin_pcie_probe(struct platform_device *pdev)
 		return ret;
 
 	kirin_pcie->gpio_id_reset = of_get_named_gpio(dev->of_node,
-						      "reset-gpio", 0);
+						      "reset-gpios", 0);
 	if (kirin_pcie->gpio_id_reset < 0)
 		return -ENODEV;
 
-- 
2.7.4

Re: [PATCH] PCI: kirin: Fix reset gpio name

[Loic Poulain]

Hi Xiaowei,

On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote:
> As documented in the device-tree bindings (pci/kirin-pcie.txt) and
> defined in existing device-tree (hi3660.dtsi), the reset gpio name
> is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource
> which makes the driver probe fail. Fix this.
>
> Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver")
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>


Are you still maintaining this driver ? Binghui's email seems to be invalid now.

Regards,
Loic

答复: [PATCH] PCI: kirin: Fix reset gpio name

[songxiaowei]

SXQncyBhIGJ1ZyBpbmRlZWQsIHRoYW5rIHlvdSB2ZXJ5IG11Y2ggZm9yIHRoZSBwYXRjaC4gSSB0
aGluayB0aGUgcGF0Y2ggaXMgb2suDQoNCi0tLS0t6YKu5Lu25Y6f5Lu2LS0tLS0NCuWPkeS7tuS6
ujogTG9pYyBQb3VsYWluIFttYWlsdG86bG9pYy5wb3VsYWluQGxpbmFyby5vcmddIA0K5Y+R6YCB
5pe26Ze0OiAyMDE45bm0NOaciDE25pelIDE5OjM1DQrmlLbku7bkuro6IHNvbmd4aWFvd2VpIDxz
b25neGlhb3dlaUBoaXNpbGljb24uY29tPjsgV2FuZ2JpbmdodWkgPHdhbmdiaW5naHVpQGhpc2ls
aWNvbi5jb20+DQrmioTpgIE6IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IEJqb3JuIEhlbGdh
YXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+OyBsb3JlbnpvLnBpZXJhbGlzaUBhcm0uY29tOyBMb2lj
IFBvdWxhaW4gPGxvaWMucG91bGFpbkBsaW5hcm8ub3JnPjsgR3VvZG9uZyBYdSA8Z3VvZG9uZy54
dUBsaW5hcm8ub3JnPg0K5Li76aKYOiBSZTogW1BBVENIXSBQQ0k6IGtpcmluOiBGaXggcmVzZXQg
Z3BpbyBuYW1lDQoNCkhpIFhpYW93ZWksDQoNCk9uIDMgQXByaWwgMjAxOCBhdCAxMToxOSwgTG9p
YyBQb3VsYWluIDxsb2ljLnBvdWxhaW5AbGluYXJvLm9yZz4gd3JvdGU6DQo+IEFzIGRvY3VtZW50
ZWQgaW4gdGhlIGRldmljZS10cmVlIGJpbmRpbmdzIChwY2kva2lyaW4tcGNpZS50eHQpIGFuZCAN
Cj4gZGVmaW5lZCBpbiBleGlzdGluZyBkZXZpY2UtdHJlZSAoaGkzNjYwLmR0c2kpLCB0aGUgcmVz
ZXQgZ3BpbyBuYW1lIGlzIA0KPiAncmVzZXQtZ3Bpb3MnLiBIb3dldmVyLCBkcml2ZXIgbG9va3Mg
Zm9yIGEgJ3Jlc2V0LWdwaW8nIHJlc291cmNlIHdoaWNoIA0KPiBtYWtlcyB0aGUgZHJpdmVyIHBy
b2JlIGZhaWwuIEZpeCB0aGlzLg0KPg0KPiBGaXhlczogZmM1MTY1ZGIyNDVhICgiUENJOiBraXJp
bjogQWRkIEhpU2lsaWNvbiBLaXJpbiBTb0MgUENJZSANCj4gY29udHJvbGxlciBkcml2ZXIiKQ0K
PiBTaWduZWQtb2ZmLWJ5OiBMb2ljIFBvdWxhaW4gPGxvaWMucG91bGFpbkBsaW5hcm8ub3JnPg0K
DQoNCkFyZSB5b3Ugc3RpbGwgbWFpbnRhaW5pbmcgdGhpcyBkcml2ZXIgPyBCaW5naHVpJ3MgZW1h
aWwgc2VlbXMgdG8gYmUgaW52YWxpZCBub3cuDQoNClJlZ2FyZHMsDQpMb2ljDQo=

Re: 答复: [PATCH] PCI: kirin: Fix reset gpio name

[Lorenzo Pieralisi]

On Mon, Apr 16, 2018 at 11:48:52AM +0000, songxiaowei wrote:
> It's a bug indeed, thank you very much for the patch. I think the
> patch is ok.

Is this an ACK ? Please provide one if you want me to merge this
fix.

Lorenzo

> -----邮件原件-----
> 发件人: Loic Poulain [mailto:loic.poulain@linaro.org] 
> 发送时间: 2018年4月16日 19:35
> 收件人: songxiaowei <songxiaowei@hisilicon.com>; Wangbinghui <wangbinghui@hisilicon.com>
> 抄送: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; lorenzo.pieralisi@arm.com; Loic Poulain <loic.poulain@linaro.org>; Guodong Xu <guodong.xu@linaro.org>
> 主题: Re: [PATCH] PCI: kirin: Fix reset gpio name
> 
> Hi Xiaowei,
> 
> On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote:
> > As documented in the device-tree bindings (pci/kirin-pcie.txt) and 
> > defined in existing device-tree (hi3660.dtsi), the reset gpio name is 
> > 'reset-gpios'. However, driver looks for a 'reset-gpio' resource which 
> > makes the driver probe fail. Fix this.
> >
> > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe 
> > controller driver")
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> 
> 
> Are you still maintaining this driver ? Binghui's email seems to be invalid now.
> 
> Regards,
> Loic

答复: 答复: [PATCH] PCI: kirin: Fix reset gpio name

[songxiaowei]

QWNrZWQtYnk6IFhpYW93ZWkgU29uZyA8c29uZ3hpYW93ZWlAaGlzaWxpY29uLmNvbT4NCg0KLS0t
LS3pgq7ku7bljp/ku7YtLS0tLQ0K5Y+R5Lu25Lq6OiBMb3JlbnpvIFBpZXJhbGlzaSBbbWFpbHRv
OmxvcmVuem8ucGllcmFsaXNpQGFybS5jb21dIA0K5Y+R6YCB5pe26Ze0OiAyMDE45bm0NOaciDE2
5pelIDIxOjQ5DQrmlLbku7bkuro6IHNvbmd4aWFvd2VpIDxzb25neGlhb3dlaUBoaXNpbGljb24u
Y29tPg0K5oqE6YCBOiBMb2ljIFBvdWxhaW4gPGxvaWMucG91bGFpbkBsaW5hcm8ub3JnPjsgV2Fu
Z2JpbmdodWkgPHdhbmdiaW5naHVpQGhpc2lsaWNvbi5jb20+OyBsaW51eC1wY2lAdmdlci5rZXJu
ZWwub3JnOyBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPjsgR3VvZG9uZyBYdSA8
Z3VvZG9uZy54dUBsaW5hcm8ub3JnPg0K5Li76aKYOiBSZTog562U5aSNOiBbUEFUQ0hdIFBDSTog
a2lyaW46IEZpeCByZXNldCBncGlvIG5hbWUNCg0KT24gTW9uLCBBcHIgMTYsIDIwMTggYXQgMTE6
NDg6NTJBTSArMDAwMCwgc29uZ3hpYW93ZWkgd3JvdGU6DQo+IEl0J3MgYSBidWcgaW5kZWVkLCB0
aGFuayB5b3UgdmVyeSBtdWNoIGZvciB0aGUgcGF0Y2guIEkgdGhpbmsgdGhlIA0KPiBwYXRjaCBp
cyBvay4NCg0KSXMgdGhpcyBhbiBBQ0sgPyBQbGVhc2UgcHJvdmlkZSBvbmUgaWYgeW91IHdhbnQg
bWUgdG8gbWVyZ2UgdGhpcyBmaXguDQoNCkxvcmVuem8NCg0KPiAtLS0tLemCruS7tuWOn+S7ti0t
LS0tDQo+IOWPkeS7tuS6ujogTG9pYyBQb3VsYWluIFttYWlsdG86bG9pYy5wb3VsYWluQGxpbmFy
by5vcmddDQo+IOWPkemAgeaXtumXtDogMjAxOOW5tDTmnIgxNuaXpSAxOTozNQ0KPiDmlLbku7bk
uro6IHNvbmd4aWFvd2VpIDxzb25neGlhb3dlaUBoaXNpbGljb24uY29tPjsgV2FuZ2JpbmdodWkg
DQo+IDx3YW5nYmluZ2h1aUBoaXNpbGljb24uY29tPg0KPiDmioTpgIE6IGxpbnV4LXBjaUB2Z2Vy
Lmtlcm5lbC5vcmc7IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+OyANCj4gbG9y
ZW56by5waWVyYWxpc2lAYXJtLmNvbTsgTG9pYyBQb3VsYWluIDxsb2ljLnBvdWxhaW5AbGluYXJv
Lm9yZz47IA0KPiBHdW9kb25nIFh1IDxndW9kb25nLnh1QGxpbmFyby5vcmc+DQo+IOS4u+mimDog
UmU6IFtQQVRDSF0gUENJOiBraXJpbjogRml4IHJlc2V0IGdwaW8gbmFtZQ0KPiANCj4gSGkgWGlh
b3dlaSwNCj4gDQo+IE9uIDMgQXByaWwgMjAxOCBhdCAxMToxOSwgTG9pYyBQb3VsYWluIDxsb2lj
LnBvdWxhaW5AbGluYXJvLm9yZz4gd3JvdGU6DQo+ID4gQXMgZG9jdW1lbnRlZCBpbiB0aGUgZGV2
aWNlLXRyZWUgYmluZGluZ3MgKHBjaS9raXJpbi1wY2llLnR4dCkgYW5kIA0KPiA+IGRlZmluZWQg
aW4gZXhpc3RpbmcgZGV2aWNlLXRyZWUgKGhpMzY2MC5kdHNpKSwgdGhlIHJlc2V0IGdwaW8gbmFt
ZSANCj4gPiBpcyAncmVzZXQtZ3Bpb3MnLiBIb3dldmVyLCBkcml2ZXIgbG9va3MgZm9yIGEgJ3Jl
c2V0LWdwaW8nIHJlc291cmNlIA0KPiA+IHdoaWNoIG1ha2VzIHRoZSBkcml2ZXIgcHJvYmUgZmFp
bC4gRml4IHRoaXMuDQo+ID4NCj4gPiBGaXhlczogZmM1MTY1ZGIyNDVhICgiUENJOiBraXJpbjog
QWRkIEhpU2lsaWNvbiBLaXJpbiBTb0MgUENJZSANCj4gPiBjb250cm9sbGVyIGRyaXZlciIpDQo+
ID4gU2lnbmVkLW9mZi1ieTogTG9pYyBQb3VsYWluIDxsb2ljLnBvdWxhaW5AbGluYXJvLm9yZz4N
Cj4gDQo+IA0KPiBBcmUgeW91IHN0aWxsIG1haW50YWluaW5nIHRoaXMgZHJpdmVyID8gQmluZ2h1
aSdzIGVtYWlsIHNlZW1zIHRvIGJlIGludmFsaWQgbm93Lg0KPiANCj4gUmVnYXJkcywNCj4gTG9p
Yw0K