[PATCH v2 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[PATCH v2 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[Shawn Guo]

The designware core function dw_pcie_host_init() already initializes
the root_bus_nr field of 'struct pcie_port', so the -1 assignment prior
to calling dw_pcie_host_init() in platform specific driver is not really
needed.  Drop it.

Changes for v2:
 - Improve commit log a bit per Thomas' suggestion.
 - Collect ACK from Thomas and Stanimir on armada8k and qcom driver.

Shawn Guo (9):
  PCI: exynos: Drop unnecessary root_bus_nr setting
  PCI: imx6: Drop unnecessary root_bus_nr setting
  PCI: keystone: Drop unnecessary root_bus_nr setting
  PCI: armada8k: Drop unnecessary root_bus_nr setting
  PCI: artpec6: Drop unnecessary root_bus_nr setting
  PCI: designware-plat: Drop unnecessary root_bus_nr setting
  PCI: histb: Drop unnecessary root_bus_nr setting
  PCI: qcom: Drop unnecessary root_bus_nr setting
  PCI: spear13xx: Drop unnecessary root_bus_nr setting

 drivers/pci/dwc/pci-exynos.c           | 1 -
 drivers/pci/dwc/pci-imx6.c             | 1 -
 drivers/pci/dwc/pci-keystone.c         | 1 -
 drivers/pci/dwc/pcie-armada8k.c        | 1 -
 drivers/pci/dwc/pcie-artpec6.c         | 1 -
 drivers/pci/dwc/pcie-designware-plat.c | 1 -
 drivers/pci/dwc/pcie-histb.c           | 1 -
 drivers/pci/dwc/pcie-qcom.c            | 1 -
 drivers/pci/dwc/pcie-spear13xx.c       | 1 -
 9 files changed, 9 deletions(-)

-- 
1.9.1

[PATCH v2 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
---
 drivers/pci/dwc/pci-exynos.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c
index 4cc1e5df8c79..cee5f2f590e2 100644
--- a/drivers/pci/dwc/pci-exynos.c
+++ b/drivers/pci/dwc/pci-exynos.c
@@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &exynos_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

[PATCH v2 2/9] PCI: imx6: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/pci/dwc/pci-imx6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index 4818ef875f8a..f330e322c1e7 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -667,7 +667,6 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &imx6_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

[PATCH v2 3/9] PCI: keystone: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/pci/dwc/pci-keystone.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
index d55ae0716adf..6ca80a21969e 100644
--- a/drivers/pci/dwc/pci-keystone.c
+++ b/drivers/pci/dwc/pci-keystone.c
@@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &keystone_pcie_host_ops;
 	ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np);
 	if (ret) {
-- 
1.9.1

[PATCH v2 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 drivers/pci/dwc/pcie-armada8k.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-armada8k.c b/drivers/pci/dwc/pcie-armada8k.c
index b587352f8b9f..2d8eb88fd4f8 100644
--- a/drivers/pci/dwc/pcie-armada8k.c
+++ b/drivers/pci/dwc/pcie-armada8k.c
@@ -171,7 +171,6 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie,
 	struct device *dev = &pdev->dev;
 	int ret;
 
-	pp->root_bus_nr = -1;
 	pp->ops = &armada8k_pcie_host_ops;
 
 	pp->irq = platform_get_irq(pdev, 0);
-- 
1.9.1

[PATCH v2 5/9] PCI: artpec6: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
---
 drivers/pci/dwc/pcie-artpec6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
index e66cede2b5b7..af78b5c23bce 100644
--- a/drivers/pci/dwc/pcie-artpec6.c
+++ b/drivers/pci/dwc/pcie-artpec6.c
@@ -399,7 +399,6 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &artpec6_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

[PATCH v2 6/9] PCI: designware-plat: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>
---
 drivers/pci/dwc/pcie-designware-plat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-designware-plat.c b/drivers/pci/dwc/pcie-designware-plat.c
index 5416aa8a07a5..6e39afefd6db 100644
--- a/drivers/pci/dwc/pcie-designware-plat.c
+++ b/drivers/pci/dwc/pcie-designware-plat.c
@@ -58,7 +58,6 @@ static int dw_plat_add_pcie_port(struct pcie_port *pp,
 			return pp->msi_irq;
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &dw_plat_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

[PATCH v2 7/9] PCI: histb: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jianguo Sun <sunjianguo1@huawei.com>
---
 drivers/pci/dwc/pcie-histb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-histb.c b/drivers/pci/dwc/pcie-histb.c
index 3611d6ce9a92..7b32e619b959 100644
--- a/drivers/pci/dwc/pcie-histb.c
+++ b/drivers/pci/dwc/pcie-histb.c
@@ -420,7 +420,6 @@ static int histb_pcie_probe(struct platform_device *pdev)
 		phy_init(hipcie->phy);
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &histb_pcie_host_ops;
 
 	platform_set_drvdata(pdev, hipcie);
-- 
1.9.1

[PATCH v2 8/9] PCI: qcom: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
---
 drivers/pci/dwc/pcie-qcom.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 5897af7d3355..a32aa024e907 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -1247,7 +1247,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	pp->root_bus_nr = -1;
 	pp->ops = &qcom_pcie_dw_ops;
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
-- 
1.9.1

[PATCH v2 9/9] PCI: spear13xx: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Pratyush Anand <pratyush.anand@gmail.com>
---
 drivers/pci/dwc/pcie-spear13xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c
index ecb58f7b7566..7d0cdfd8138b 100644
--- a/drivers/pci/dwc/pcie-spear13xx.c
+++ b/drivers/pci/dwc/pcie-spear13xx.c
@@ -210,7 +210,6 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
 		return ret;
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &spear13xx_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

Re: [PATCH v2 9/9] PCI: spear13xx: Drop unnecessary root_bus_nr setting

[Pratyush Anand]

On Fri, May 11, 2018 at 5:50 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Pratyush Anand <pratyush.anand@gmail.com>

Acked-by: Pratyush Anand <pratyush.anand@gmail.com>

> ---
>  drivers/pci/dwc/pcie-spear13xx.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c
> index ecb58f7b7566..7d0cdfd8138b 100644
> --- a/drivers/pci/dwc/pcie-spear13xx.c
> +++ b/drivers/pci/dwc/pcie-spear13xx.c
> @@ -210,7 +210,6 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
>                 return ret;
>         }
>
> -       pp->root_bus_nr = -1;
>         pp->ops = &spear13xx_pcie_host_ops;
>
>         ret = dw_pcie_host_init(pp);
> --
> 1.9.1
>

Re: [PATCH v2 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[Lorenzo Pieralisi]

On Fri, May 11, 2018 at 08:20:10AM +0800, Shawn Guo wrote:
> The designware core function dw_pcie_host_init() already initializes
> the root_bus_nr field of 'struct pcie_port', so the -1 assignment prior
> to calling dw_pcie_host_init() in platform specific driver is not really
> needed.  Drop it.
> 
> Changes for v2:
>  - Improve commit log a bit per Thomas' suggestion.
>  - Collect ACK from Thomas and Stanimir on armada8k and qcom driver.
> 
> Shawn Guo (9):
>   PCI: exynos: Drop unnecessary root_bus_nr setting
>   PCI: imx6: Drop unnecessary root_bus_nr setting
>   PCI: keystone: Drop unnecessary root_bus_nr setting
>   PCI: armada8k: Drop unnecessary root_bus_nr setting
>   PCI: artpec6: Drop unnecessary root_bus_nr setting
>   PCI: designware-plat: Drop unnecessary root_bus_nr setting
>   PCI: histb: Drop unnecessary root_bus_nr setting
>   PCI: qcom: Drop unnecessary root_bus_nr setting
>   PCI: spear13xx: Drop unnecessary root_bus_nr setting
> 
>  drivers/pci/dwc/pci-exynos.c           | 1 -
>  drivers/pci/dwc/pci-imx6.c             | 1 -
>  drivers/pci/dwc/pci-keystone.c         | 1 -
>  drivers/pci/dwc/pcie-armada8k.c        | 1 -
>  drivers/pci/dwc/pcie-artpec6.c         | 1 -
>  drivers/pci/dwc/pcie-designware-plat.c | 1 -
>  drivers/pci/dwc/pcie-histb.c           | 1 -
>  drivers/pci/dwc/pcie-qcom.c            | 1 -
>  drivers/pci/dwc/pcie-spear13xx.c       | 1 -
>  9 files changed, 9 deletions(-)

I need ACKs from respective maintainers to merge this series.

Thanks,
Lorenzo

Re: [PATCH v2 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[Lorenzo Pieralisi]

On Fri, May 11, 2018 at 08:20:10AM +0800, Shawn Guo wrote:
> The designware core function dw_pcie_host_init() already initializes
> the root_bus_nr field of 'struct pcie_port', so the -1 assignment prior
> to calling dw_pcie_host_init() in platform specific driver is not really
> needed.  Drop it.
> 
> Changes for v2:
>  - Improve commit log a bit per Thomas' suggestion.
>  - Collect ACK from Thomas and Stanimir on armada8k and qcom driver.

Hi Shawn,

would you mind please rebasing it against v4.18-rc1 and resend with
CC all the controllers maintainers so that we can get ACKs and send it
for v4.19 ?

Thanks a lot for doing this.

Lorenzo

> Shawn Guo (9):
>   PCI: exynos: Drop unnecessary root_bus_nr setting
>   PCI: imx6: Drop unnecessary root_bus_nr setting
>   PCI: keystone: Drop unnecessary root_bus_nr setting
>   PCI: armada8k: Drop unnecessary root_bus_nr setting
>   PCI: artpec6: Drop unnecessary root_bus_nr setting
>   PCI: designware-plat: Drop unnecessary root_bus_nr setting
>   PCI: histb: Drop unnecessary root_bus_nr setting
>   PCI: qcom: Drop unnecessary root_bus_nr setting
>   PCI: spear13xx: Drop unnecessary root_bus_nr setting
> 
>  drivers/pci/dwc/pci-exynos.c           | 1 -
>  drivers/pci/dwc/pci-imx6.c             | 1 -
>  drivers/pci/dwc/pci-keystone.c         | 1 -
>  drivers/pci/dwc/pcie-armada8k.c        | 1 -
>  drivers/pci/dwc/pcie-artpec6.c         | 1 -
>  drivers/pci/dwc/pcie-designware-plat.c | 1 -
>  drivers/pci/dwc/pcie-histb.c           | 1 -
>  drivers/pci/dwc/pcie-qcom.c            | 1 -
>  drivers/pci/dwc/pcie-spear13xx.c       | 1 -
>  9 files changed, 9 deletions(-)
> 
> -- 
> 1.9.1
> 

Re: [PATCH v2 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[Shawn Guo]

On Fri, Jun 29, 2018 at 10:14 PM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> would you mind please rebasing it against v4.18-rc1 and resend with
> CC all the controllers maintainers so that we can get ACKs and send it
> for v4.19 ?

No problem.  Will do.

Shawn