* [PATCH 1/1] PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver compile support
@ 2018-08-01 7:04 Subrahmanya Lingappa
2018-08-01 9:47 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Subrahmanya Lingappa @ 2018-08-01 7:04 UTC (permalink / raw)
To: linux-pci, bhelgaas, lorenzo.pieralisi; +Cc: Subrahmanya Lingappa
Adds missing support for compilation of Mobiveil PCIe Host
Bridge IP driver.
Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
---
drivers/pci/controller/Kconfig | 6 ++++++
drivers/pci/controller/Makefile | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index cc9fa02..ce26d7a 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -186,6 +186,12 @@ config PCIE_ALTERA_MSI
Say Y here if you want PCIe MSI support for the Altera FPGA.
This MSI driver supports Altera MSI to GIC controller IP.
+config PCIE_MOBIVEIL
+ bool "Mobiveil AXI PCIe host bridge support"
+ help
+ Say 'Y' here if you want kernel to support the Mobiveil AXI PCIe
+ Host Bridge driver.
+
config PCI_HOST_THUNDER_PEM
bool "Cavium Thunder PCIe controller to off-chip devices"
depends on ARM64 || COMPILE_TEST
diff --git a/drivers/pci/controller/Makefile b/drivers/pci/controller/Makefile
index 24322b9..7c20553 100644
--- a/drivers/pci/controller/Makefile
+++ b/drivers/pci/controller/Makefile
@@ -22,6 +22,7 @@ obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o
obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o
obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o
obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o
+obj-$(CONFIG_PCIE_MOBIVEIL) += pcie-mobiveil.o
obj-$(CONFIG_PCIE_ROCKCHIP) += pcie-rockchip.o
obj-$(CONFIG_PCIE_ROCKCHIP_EP) += pcie-rockchip-ep.o
obj-$(CONFIG_PCIE_ROCKCHIP_HOST) += pcie-rockchip-host.o
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver compile support
2018-08-01 7:04 [PATCH 1/1] PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver compile support Subrahmanya Lingappa
@ 2018-08-01 9:47 ` Lorenzo Pieralisi
2018-08-03 5:26 ` Subrahmanya Lingappa
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Pieralisi @ 2018-08-01 9:47 UTC (permalink / raw)
To: Subrahmanya Lingappa, bhelgaas; +Cc: linux-pci
On Wed, Aug 01, 2018 at 03:04:07AM -0400, Subrahmanya Lingappa wrote:
> Adds missing support for compilation of Mobiveil PCIe Host
> Bridge IP driver.
>
> Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> ---
> drivers/pci/controller/Kconfig | 6 ++++++
> drivers/pci/controller/Makefile | 1 +
> 2 files changed, 7 insertions(+)
Have you tried compiling it ? (No).
I CC'ed you on this series:
https://patchwork.ozlabs.org/patch/950977/
The mainline kernel is not a dumping ground where you drop you
code and forget about it - you did not even compile the driver,
let me remind you that you are supposed to maintain it.
I will ask Bjorn to revert the driver, I am sorry about that
but that's not acceptable from a maintainership perspective.
Lorenzo
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index cc9fa02..ce26d7a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -186,6 +186,12 @@ config PCIE_ALTERA_MSI
> Say Y here if you want PCIe MSI support for the Altera FPGA.
> This MSI driver supports Altera MSI to GIC controller IP.
>
> +config PCIE_MOBIVEIL
> + bool "Mobiveil AXI PCIe host bridge support"
> + help
> + Say 'Y' here if you want kernel to support the Mobiveil AXI PCIe
> + Host Bridge driver.
> +
> config PCI_HOST_THUNDER_PEM
> bool "Cavium Thunder PCIe controller to off-chip devices"
> depends on ARM64 || COMPILE_TEST
> diff --git a/drivers/pci/controller/Makefile b/drivers/pci/controller/Makefile
> index 24322b9..7c20553 100644
> --- a/drivers/pci/controller/Makefile
> +++ b/drivers/pci/controller/Makefile
> @@ -22,6 +22,7 @@ obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o
> obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o
> obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o
> obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o
> +obj-$(CONFIG_PCIE_MOBIVEIL) += pcie-mobiveil.o
> obj-$(CONFIG_PCIE_ROCKCHIP) += pcie-rockchip.o
> obj-$(CONFIG_PCIE_ROCKCHIP_EP) += pcie-rockchip-ep.o
> obj-$(CONFIG_PCIE_ROCKCHIP_HOST) += pcie-rockchip-host.o
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver compile support
2018-08-01 9:47 ` Lorenzo Pieralisi
@ 2018-08-03 5:26 ` Subrahmanya Lingappa
0 siblings, 0 replies; 3+ messages in thread
From: Subrahmanya Lingappa @ 2018-08-03 5:26 UTC (permalink / raw)
To: Lorenzo Pieralisi; +Cc: Bjorn Helgaas, linux-pci
Lorenzo,
My apologies, I did compile and submitted all those 12 versions which
got accepted,
I was away for a while and missed the mails, I'll try to be more
attentive now on.
Thanks for your time again.
Subrahmanya
On Wed, Aug 1, 2018 at 3:17 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> On Wed, Aug 01, 2018 at 03:04:07AM -0400, Subrahmanya Lingappa wrote:
>> Adds missing support for compilation of Mobiveil PCIe Host
>> Bridge IP driver.
>>
>> Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
>> ---
>> drivers/pci/controller/Kconfig | 6 ++++++
>> drivers/pci/controller/Makefile | 1 +
>> 2 files changed, 7 insertions(+)
>
> Have you tried compiling it ? (No).
>
> I CC'ed you on this series:
>
> https://patchwork.ozlabs.org/patch/950977/
>
> The mainline kernel is not a dumping ground where you drop you
> code and forget about it - you did not even compile the driver,
> let me remind you that you are supposed to maintain it.
>
> I will ask Bjorn to revert the driver, I am sorry about that
> but that's not acceptable from a maintainership perspective.
>
> Lorenzo
>
>> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
>> index cc9fa02..ce26d7a 100644
>> --- a/drivers/pci/controller/Kconfig
>> +++ b/drivers/pci/controller/Kconfig
>> @@ -186,6 +186,12 @@ config PCIE_ALTERA_MSI
>> Say Y here if you want PCIe MSI support for the Altera FPGA.
>> This MSI driver supports Altera MSI to GIC controller IP.
>>
>> +config PCIE_MOBIVEIL
>> + bool "Mobiveil AXI PCIe host bridge support"
>> + help
>> + Say 'Y' here if you want kernel to support the Mobiveil AXI PCIe
>> + Host Bridge driver.
>> +
>> config PCI_HOST_THUNDER_PEM
>> bool "Cavium Thunder PCIe controller to off-chip devices"
>> depends on ARM64 || COMPILE_TEST
>> diff --git a/drivers/pci/controller/Makefile b/drivers/pci/controller/Makefile
>> index 24322b9..7c20553 100644
>> --- a/drivers/pci/controller/Makefile
>> +++ b/drivers/pci/controller/Makefile
>> @@ -22,6 +22,7 @@ obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o
>> obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o
>> obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o
>> obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o
>> +obj-$(CONFIG_PCIE_MOBIVEIL) += pcie-mobiveil.o
>> obj-$(CONFIG_PCIE_ROCKCHIP) += pcie-rockchip.o
>> obj-$(CONFIG_PCIE_ROCKCHIP_EP) += pcie-rockchip-ep.o
>> obj-$(CONFIG_PCIE_ROCKCHIP_HOST) += pcie-rockchip-host.o
>> --
>> 1.8.3.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-03 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-01 7:04 [PATCH 1/1] PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver compile support Subrahmanya Lingappa
2018-08-01 9:47 ` Lorenzo Pieralisi
2018-08-03 5:26 ` Subrahmanya Lingappa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).