Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Schöfegger Stefan" <Stefan.Schoefegger@ginzinger.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	open list <linux-kernel@vger.kernel.org>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"moderated list:PCI DRIVER FOR IMX6"
	<linux-arm-kernel@lists.infradead.org>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option
Date: Mon, 19 Jun 2017 06:43:58 +0000	[thread overview]
Message-ID: <1552752.riIkOpKaxW@en-pc05> (raw)
In-Reply-To: <CAOMZO5C03MwGkQSrJr-AeG98q84iyWnKj2GSvveJ6xKL+Y-9EQ@mail.gmail.com>

On Wednesday, June 14, 2017 4:11:29 PM CEST Fabio Estevam wrote:
> On Wed, Jun 14, 2017 at 2:52 AM, Sch=F6fegger Stefan
>=20
> <Stefan.Schoefegger@ginzinger.com> wrote:
> > device). The bitrate and de-emphasis must be switched. The driver (with=
out
> > this patches) does not allow to switch to gen2 because it falls back to
> > gen1. It is impossible to generate the gen2 test pattern.
>=20
> If you pass 'fsl,max-link-speed =3D <2>;' in your device tree, then it
> will allow gen2.
>=20
> From Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt:
>=20
> "- fsl,max-link-speed: Specify PCI gen for link capability. Must be '2' f=
or
>   gen2, otherwise will default to gen1. Note that the IMX6 LVDS clock
> outputs do not meet gen2 jitter requirements and thus for gen2 capability=
 a
> gen2 compliant clock generator should be used and configured."
>=20
> Wouldn't this solve the problem?

No, it only sets the maximum allowed link speed but it is forced to gen1=20
before.

During compliance test there is no real link established and there is no li=
nk=20
speed negotiation, the phy is in a special compliance test state.

Stefan

      reply	other threads:[~2017-06-19  6:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1472121518-9340-1-git-send-email-stefan.schoefegger@ginzinger.com>
2017-06-07 11:36 ` [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Stefan Schoefegger
2017-06-12 23:49   ` Bjorn Helgaas
2017-06-13  2:00     ` Richard Zhu
2017-06-13  5:55       ` Schöfegger Stefan
2017-06-13  5:43     ` Schöfegger Stefan
2017-06-13 13:58       ` Bjorn Helgaas
2017-06-14  5:52         ` Schöfegger Stefan
2017-06-14 19:11           ` Fabio Estevam
2017-06-19  6:43             ` Schöfegger Stefan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552752.riIkOpKaxW@en-pc05 \
    --to=stefan.schoefegger@ginzinger.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=festevam@gmail.com \
    --cc=helgaas@kernel.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox