From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Honghui Zhang <honghui.zhang@mediatek.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
<linux-pci@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] PCI: mediatek: get optional clock by devm_clk_get_optional()
Date: Sun, 31 Mar 2019 20:40:08 +0800 [thread overview]
Message-ID: <1554036008.10179.174.camel@mhfsdcap03> (raw)
In-Reply-To: <1554027049.21644.0.camel@mtkswgap22>
Hi Ryder,
On Sun, 2019-03-31 at 18:10 +0800, Ryder Lee wrote:
> On Sat, 2019-03-30 at 18:00 +0800, Chunfeng Yun wrote:
> > Use devm_clk_get_optional() to get optional clock
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/pci/controller/pcie-mediatek.c | 46 ++++++--------------------
> > 1 file changed, 11 insertions(+), 35 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
> > index 0b6c72804e03..9a66a018489b 100644
> > --- a/drivers/pci/controller/pcie-mediatek.c
> > +++ b/drivers/pci/controller/pcie-mediatek.c
> > @@ -915,49 +915,25 @@ static int mtk_pcie_parse_port(struct mtk_pcie *pcie,
> >
> > /* sys_ck might be divided into the following parts in some chips */
> > snprintf(name, sizeof(name), "ahb_ck%d", slot);
> > - port->ahb_ck = devm_clk_get(dev, name);
> > - if (IS_ERR(port->ahb_ck)) {
> > - if (PTR_ERR(port->ahb_ck) == -EPROBE_DEFER)
> > - return -EPROBE_DEFER;
> > -
> > - port->ahb_ck = NULL;
> > - }
> > + port->ahb_ck = devm_clk_get_optional(dev, name);
> > + if (IS_ERR(port->ahb_ck))
> > + return PTR_ERR(port->ahb_ck);
> >
> > snprintf(name, sizeof(name), "axi_ck%d", slot);
> > - port->axi_ck = devm_clk_get(dev, name);
> > - if (IS_ERR(port->axi_ck)) {
> > - if (PTR_ERR(port->axi_ck) == -EPROBE_DEFER)
> > - return -EPROBE_DEFER;
> > -
> > - port->axi_ck = NULL;
> > - }
> > + port->axi_ck = devm_clk_get_optional(dev, name);
> > + return PTR_ERR(port->axi_ck);
> >
> > snprintf(name, sizeof(name), "aux_ck%d", slot);
> > - port->aux_ck = devm_clk_get(dev, name);
> > - if (IS_ERR(port->aux_ck)) {
> > - if (PTR_ERR(port->aux_ck) == -EPROBE_DEFER)
> > - return -EPROBE_DEFER;
> > -
> > - port->aux_ck = NULL;
> > - }
> > + port->aux_ck = devm_clk_get_optional(dev, name);
> > + return PTR_ERR(port->aux_ck);
> >
> > snprintf(name, sizeof(name), "obff_ck%d", slot);
> > - port->obff_ck = devm_clk_get(dev, name);
> > - if (IS_ERR(port->obff_ck)) {
> > - if (PTR_ERR(port->obff_ck) == -EPROBE_DEFER)
> > - return -EPROBE_DEFER;
> > -
> > - port->obff_ck = NULL;
> > - }
> > + port->obff_ck = devm_clk_get_optional(dev, name);
> > + return PTR_ERR(port->obff_ck);
> >
> > snprintf(name, sizeof(name), "pipe_ck%d", slot);
> > - port->pipe_ck = devm_clk_get(dev, name);
> > - if (IS_ERR(port->pipe_ck)) {
> > - if (PTR_ERR(port->pipe_ck) == -EPROBE_DEFER)
> > - return -EPROBE_DEFER;
> > -
> > - port->pipe_ck = NULL;
> > - }
> > + port->pipe_ck = devm_clk_get_optional(dev, name);
> > + return PTR_ERR(port->pipe_ck);
> >
> > snprintf(name, sizeof(name), "pcie-rst%d", slot);
> > port->reset = devm_reset_control_get_optional_exclusive(dev, name);
>
> if (IS_ERR(...)) ?
Very sorry for my stupid mistake:(
will send new version
>
prev parent reply other threads:[~2019-03-31 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 10:00 [PATCH] PCI: mediatek: get optional clock by devm_clk_get_optional() Chunfeng Yun
2019-03-31 0:45 ` Honghui Zhang
2019-03-31 10:10 ` Ryder Lee
2019-03-31 12:40 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554036008.10179.174.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=bhelgaas@google.com \
--cc=honghui.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).