From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D99C10F0E for ; Mon, 15 Apr 2019 08:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE5A920651 for ; Mon, 15 Apr 2019 08:38:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725798AbfDOIiv (ORCPT ); Mon, 15 Apr 2019 04:38:51 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:50325 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfDOIiv (ORCPT ); Mon, 15 Apr 2019 04:38:51 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hFx8a-0004Hh-TJ; Mon, 15 Apr 2019 10:38:48 +0200 Message-ID: <1555317528.2983.2.camel@pengutronix.de> Subject: Re: [PATCH v4 11/11] PCI: imx6: Use usleep_range() in imx6_pcie_enable_ref_clk() From: Lucas Stach To: Andrey Smirnov , linux-pci@vger.kernel.org Cc: Lorenzo Pieralisi , Bjorn Helgaas , Chris Healy , linux-kernel@vger.kernel.org Date: Mon, 15 Apr 2019 10:38:48 +0200 In-Reply-To: <20190415004632.5907-12-andrew.smirnov@gmail.com> References: <20190415004632.5907-1-andrew.smirnov@gmail.com> <20190415004632.5907-12-andrew.smirnov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Am Sonntag, den 14.04.2019, 17:46 -0700 schrieb Andrey Smirnov: > imx6_pcie_enable_ref_clk() is never called in atomic context, so > there's no need to use udelay(). Replace it with usleep_range(). > > Signed-off-by: Andrey Smirnov > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Chris Healy > Cc: Lucas Stach > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org Reviewed-by: Lucas Stach > --- >  drivers/pci/controller/dwc/pci-imx6.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 3e45f49b8a4f..c6d6bde4d860 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -449,7 +449,7 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie) > >    * reset time is too short, cannot meet the requirement. > >    * add one ~10us delay here. > >    */ > > - udelay(10); > > + usleep_range(10, 100); > >   regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, > >      IMX6Q_GPR1_PCIE_REF_CLK_EN, 1 << 16); > >   break;