From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E50A1DC184 for ; Wed, 4 Sep 2024 16:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725468956; cv=none; b=cQcFfuxeQqAvuwUYEoM229x1jr4Bzn96S16yLbvJgetiG1UIpVieT2FzXLWJXfm6myv9nuzTYCXQXwwlb+FqeezAk4IWxApIIw+hUaQxHxjTPKqdixrD2al0VHmV6VGvKF/2qDpAbc6Q2MpAtkjhaEOauHB9bPXxQmeb4zNAcNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725468956; c=relaxed/simple; bh=tpbc6MzDLkqXDnv8L0UfBuzo0UTvSaG2dQtmH6H3UB8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=b5BmMfaChZFy/IOEeulNDu/AKzjivJqVV+UahkmeTDuk2XhTS8V21DCNjXpbmqB8BrZwmFmRhoFn+KLh8p5QHwN9JfSQCiKihBMseHEmoRjS/Jl3tY4AFx9rSHA3tG5W9ttHBoM/8qStzgMHWMgrCAl8/1tNMuUUjAuD4Xj6hVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hnoMTIeP; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hnoMTIeP" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6c3552ce7faso8992216d6.1 for ; Wed, 04 Sep 2024 09:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1725468952; x=1726073752; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FHAijoASNp+gJRk6KrYMDvs2NpHhscFYYgL4xfA1Ej0=; b=hnoMTIePPgGvEWRMmvBVDo/jGaFtaG7x3+au87GxUbm6tin1+rgkAySH4eOeURCvQL 77NdZAZBdfOF2MEc0k5CipMJ58aJ9VPs/9pCLxINbxcs2TlciymK9cmrFfs07fUV9ptU DLLrJg4sU2Rj5lAuqcpY2hqj12pAHLWiTnG+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725468952; x=1726073752; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FHAijoASNp+gJRk6KrYMDvs2NpHhscFYYgL4xfA1Ej0=; b=ES7XzxTXd32LCqtOrbbXdwOnHnoJciLfP/5iRLbeT0+24eLQgFdThLFhaJyTq8N/5h W9AMPfi6Xg/0tQDV7R4J6zSceMrYUX3t6wTTcOIX+IEWuSssaSNTtMu5Ry4i3linh6ca ABxbLqQ9kWEHv0qHM2HaqIyx7lJhKl/4hzjPj4v516nxnan+zh70aTGL39WokYLAqJM6 t2Qm0Ct0IBvVY0mcSK3Oz0+CveVXjvbvAfNJc1ILCmU3i/6rOXzwAydiBjQWehrPXJDA 1E3CihwWb6UPW2+HjFWz6KxOYmayT7xvliR5APAFte7EqSLJIhtB4cRDnjpDVjcUAW8i 2Jlg== X-Gm-Message-State: AOJu0Yw9lzGJEPNywWCr13pPh9xeZReZVLXlUrCecDnKC2XCXfLF5U2a 10JshgBxcqCR5wEfRD15mMTwWimvefoEGdQjlJx6Y/hoVS4FPfLXo70ARXD5YPXbZlzS9972QVQ UXg== X-Google-Smtp-Source: AGHT+IFTCSaYeyRsECdDZKJj9c6nIvWUrYvHfZJxoUXUZVWGhMsEbo3lPglw+z9Mhq6dD7+ks4oGrA== X-Received: by 2002:a05:6214:21ca:b0:6c3:575a:a975 with SMTP id 6a1803df08f44-6c518de50e9mr39113966d6.2.1725468952203; Wed, 04 Sep 2024 09:55:52 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c340c97b14sm64989626d6.77.2024.09.04.09.55.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 09:55:51 -0700 (PDT) Message-ID: <159c5fcf-709d-42ba-8d45-a70b109fe261@broadcom.com> Date: Wed, 4 Sep 2024 09:55:48 -0700 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: florian.fainelli@broadcom.com Subject: Re: [PATCH next] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_setup() To: Riyan Dhiman , jim2101024@gmail.com, nsaenz@kernel.org, lorian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240904161953.46790-2-riyandhiman14@gmail.com> Content-Language: en-US Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20240904161953.46790-2-riyandhiman14@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/4/24 09:19, Riyan Dhiman wrote: > Change num_inbound_wins from u8 to int in brcm_pcie_setup() function to correctly > handle potential negative error codes returned by brcm_pcie_get_inbound_wins(). > The u8 type was inappropriate for capturing the function's return value, > which can include error codes. > > Signed-off-by: Riyan Dhiman This looks fine, however it seems like we could either: - update brcm_pcie_get_inbound_wins() to take a reference to an u8 and assign num_inbound_wins directly plus return a negative error code or - update brcm_pcie_get_inbound_wins() to return 0 when encountering an error We should have at least 1 inbound window to operate this PCIe controller, so if we get 0, nothing useful is going to happen. Deferring to Jim as to whether he prefers to take your patch or fix it in a different way. Thanks! -- Florian