linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: devicetree@vger.kernel.org, kw@linux.com, bhelgaas@google.com,
	andersson@kernel.org, linux-kernel@vger.kernel.org,
	konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
	linux-pci@vger.kernel.org, lpieralisi@kernel.org,
	dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
	robh+dt@kernel.org
Subject: Re: [PATCH 10/11] dt-bindings: PCI: qcom-ep: Add support for SM8450 SoC
Date: Sun, 28 Aug 2022 09:21:16 -0500	[thread overview]
Message-ID: <1661696476.862958.3159703.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220826181923.251564-11-manivannan.sadhasivam@linaro.org>

On Fri, 26 Aug 2022 23:49:22 +0530, Manivannan Sadhasivam wrote:
> Add devicetree bindings support for SM8450 SoC. Only the clocks are
> different on this platform, rest is same as SDX55.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 27 +++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml:15:5: [error] duplication of key "const" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dts'
Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml:15:5: found duplicate key "const" with value "qcom,sm8450-pcie-ep" (original value: "qcom,sdx55-pcie-ep")
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml:15:5: found duplicate key "const" with value "qcom,sm8450-pcie-ep" (original value: "qcom,sdx55-pcie-ep")
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml: ignoring, error parsing file
make: *** [Makefile:1420: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  reply	other threads:[~2022-08-28 14:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 18:19 [PATCH 00/11] Improvements to the Qcom PCIe Endpoint driver Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 01/11] PCI: qcom-ep: Add kernel-doc for qcom_pcie_ep structure Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 02/11] PCI: qcom-ep: Do not use hardcoded clks in driver Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 03/11] PCI: qcom-ep: Make use of the cached dev pointer Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 04/11] PCI: qcom-ep: Add eDMA support Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 05/11] PCI: qcom-ep: Disable IRQs during driver remove Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 06/11] PCI: qcom-ep: Add debugfs support for expose link transition counts Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 07/11] dt-bindings: PCI: qcom-ep: Make PERST separation optional Manivannan Sadhasivam
2022-08-28 15:12   ` Krzysztof Kozlowski
2022-08-26 18:19 ` [PATCH 08/11] " Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 09/11] dt-bindings: PCI: qcom-ep: Define clocks per platform Manivannan Sadhasivam
2022-08-28 15:14   ` Krzysztof Kozlowski
2022-08-28 15:20   ` Krzysztof Kozlowski
2022-08-30 11:56     ` Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 10/11] dt-bindings: PCI: qcom-ep: Add support for SM8450 SoC Manivannan Sadhasivam
2022-08-28 14:21   ` Rob Herring [this message]
2022-08-28 15:17   ` Krzysztof Kozlowski
2022-08-30 11:57     ` Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 11/11] " Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1661696476.862958.3159703.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).