Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: gustavo.pimentel@synopsys.com, robh+dt@kernel.org,
	mani@kernel.org, bhelgaas@google.com, lpieralisi@kernel.org,
	fancer.lancer@gmail.com, kw@linux.com, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	jingoohan1@gmail.com, marek.vasut+renesas@gmail.com,
	kishon@kernel.org
Subject: Re: [PATCH v12 15/19] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint
Date: Fri, 14 Apr 2023 07:37:05 -0500	[thread overview]
Message-ID: <168147485020.3576451.4333163339018554395.robh@kernel.org> (raw)
In-Reply-To: <20230414061622.2930995-16-yoshihiro.shimoda.uh@renesas.com>


On Fri, 14 Apr 2023 15:16:18 +0900, Yoshihiro Shimoda wrote:
> Document bindings for Renesas R-Car Gen4 and R-Car S4-8 (R8A779F0)
> PCIe endpoint module.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> ---
>  .../bindings/pci/rcar-gen4-pci-ep.yaml        | 98 +++++++++++++++++++
>  1 file changed, 98 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.example.dtb: pcie-ep@e65d0000: reg: [[0, 3864854528, 0, 8192], [0, 3864864768, 0, 2048], [0, 3864866816, 0, 8192], [0, 3864875008, 0, 4608], [0, 3864879616, 0, 3584], [0, 4261412864, 0, 4194304]] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.example.dtb: pcie-ep@e65d0000: reg-names: ['dbi', 'dbi2', 'atu', 'dma', 'app', 'addr_space'] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230414061622.2930995-16-yoshihiro.shimoda.uh@renesas.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2023-04-14 12:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  6:16 [PATCH v12 00/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe support Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 01/19] PCI: Add PCI_EXP_LNKCAP_MLW macros Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 02/19] PCI: Add INtx Mechanism Messages macros Yoshihiro Shimoda
2023-04-14 18:59   ` Bjorn Helgaas
2023-04-17  5:05     ` Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 03/19] PCI: Add PCI_HEADER_TYPE_MULTI_FUNC Yoshihiro Shimoda
2023-04-14 18:58   ` Bjorn Helgaas
2023-04-17  4:51     ` Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 04/19] PCI: dwc: Add dw_pcie_link_set_max_link_width() Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 05/19] PCI: dwc: Add dw_pcie_link_set_max_width() Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 06/19] PCI: dwc: Add dw_pcie_link_set_max_cap_width() Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 07/19] PCI: dwc: Expose dw_pcie_ep_exit() to module Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 08/19] PCI: dwc: Introduce struct dw_pcie_outbound_atu Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 09/19] PCI: dwc: Add members into " Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 10/19] PCI: dwc: Change arguments of dw_pcie_prog_ep_outbound_atu() Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 11/19] PCI: dwc: Add support for triggering legacy IRQs Yoshihiro Shimoda
2023-04-14 19:42   ` Bjorn Helgaas
2023-04-17  8:09     ` Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 12/19] PCI: dwc: Add EDMA_UNROLL capability flag Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 13/19] PCI: dwc: Introduce .ep_pre_init() and .ep_deinit() Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 14/19] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host Yoshihiro Shimoda
2023-04-14 12:37   ` Rob Herring
2023-04-17  1:10     ` Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 15/19] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint Yoshihiro Shimoda
2023-04-14 12:37   ` Rob Herring [this message]
2023-04-17  1:11     ` Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 16/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe Host support Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 17/19] PCI: rcar-gen4-ep: Add R-Car Gen4 PCIe Endpoint support Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 18/19] MAINTAINERS: Update PCI DRIVER FOR RENESAS R-CAR for R-Car Gen4 Yoshihiro Shimoda
2023-04-14  6:16 ` [PATCH v12 19/19] misc: pci_endpoint_test: Add Device ID for R-Car S4-8 PCIe controller Yoshihiro Shimoda
2023-04-20 20:41 ` [PATCH v12 00/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe support Serge Semin
2023-04-20 20:45   ` Serge Semin
2023-04-25 11:33     ` Yoshihiro Shimoda
2023-04-25 12:50       ` Serge Semin
2023-04-25 23:42         ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168147485020.3576451.4333163339018554395.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox