From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:55932 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934414AbaBDVrF (ORCPT ); Tue, 4 Feb 2014 16:47:05 -0500 Date: Tue, 4 Feb 2014 13:47:04 -0800 (PST) From: Arvind Kumar To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, pv-drivers@vmware.com, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Message-ID: <1720135544.11645858.1391550424291.JavaMail.root@vmware.com> In-Reply-To: <9a6fa1d91c1f23ee0bbde7c854ce03f22054345a.1391512266.git.agordeev@redhat.com> References: <9a6fa1d91c1f23ee0bbde7c854ce03f22054345a.1391512266.git.agordeev@redhat.com> Subject: Re: [PATCH 22/22] vmw_pvscsi: Use pci_enable_msix_range() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-pci-owner@vger.kernel.org List-ID: Looks fine to me. Acked-by: Arvind Kumar Thanks! Arvind ----- Original Message ----- From: "Alexander Gordeev" To: linux-kernel@vger.kernel.org Cc: "Alexander Gordeev" , "Arvind Kumar" , pv-drivers@vmware.com, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Sent: Tuesday, February 4, 2014 3:17:08 AM Subject: [PATCH 22/22] vmw_pvscsi: Use pci_enable_msix_range() As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev Cc: Arvind Kumar Cc: pv-drivers@vmware.com Cc: linux-scsi@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/scsi/vmw_pvscsi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index b9755ec..c521f8e 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -1078,8 +1078,8 @@ static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter, struct msix_entry entry = { 0, PVSCSI_VECTOR_COMPLETION }; int ret; - ret = pci_enable_msix(adapter->dev, &entry, 1); - if (ret) + ret = pci_enable_msix_range(adapter->dev, &entry, 1, 1); + if (ret < 0) return ret; *irq = entry.vector; -- 1.7.7.6