From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
Cc: linux-kernel@vger.kernel.org, abel.vesa@linaro.org,
linux-pci@vger.kernel.org, linux-phy@lists.infradead.org,
kw@linux.com, johan+linaro@kernel.org,
neil.armstrong@linaro.org, lpieralisi@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
kishon@kernel.org, andersson@kernel.org,
dmitry.baryshkov@linaro.org, konradybcio@kernel.org,
quic_krichai@quicinc.com, krzk+dt@kernel.org,
bhelgaas@google.com, manivannan.sadhasivam@linaro.org,
quic_qianyu@quicinc.com
Subject: Re: [PATCH v3 1/4] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller
Date: Mon, 10 Mar 2025 03:23:29 -0500 [thread overview]
Message-ID: <174159500913.3380799.14221924313975247180.robh@kernel.org> (raw)
In-Reply-To: <20250310065613.151598-2-quic_ziyuzhan@quicinc.com>
On Mon, 10 Mar 2025 14:56:10 +0800, Ziyue Zhang wrote:
> From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>
> Add dedicated schema for the PCIe controllers found on QCS615.
> Due to qcs615's clock-names do not match any of the existing
> dt-bindings, a new compatible for qcs615 is needed.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
> ---
> .../bindings/pci/qcom,qcs615-pcie.yaml | 160 ++++++++++++++++++
> 1 file changed, 160 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/qcom,qcs615-pcie.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/pci/qcom,qcs615-pcie.example.dts:58.35-36 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/pci/qcom,qcs615-pcie.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250310065613.151598-2-quic_ziyuzhan@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-10 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 6:56 [PATCH v3 0/4] pci: qcom: Add QCS615 PCIe support Ziyue Zhang
2025-03-10 6:56 ` [PATCH v3 1/4] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller Ziyue Zhang
2025-03-10 7:18 ` Krzysztof Kozlowski
2025-03-10 8:35 ` Krzysztof Kozlowski
2025-03-10 8:23 ` Rob Herring (Arm) [this message]
2025-03-10 6:56 ` [PATCH v3 2/4] arm64: dts: qcom: qcs615: enable pcie Ziyue Zhang
2025-03-10 8:38 ` Krzysztof Kozlowski
2025-03-11 9:48 ` Konrad Dybcio
2025-03-10 6:56 ` [PATCH v3 3/4] arm64: dts: qcom: qcs615-ride: Enable PCIe interface Ziyue Zhang
2025-03-11 9:06 ` kernel test robot
2025-03-10 6:56 ` [PATCH v3 4/4] PCI: qcom: Add support for QCS615 SoC Ziyue Zhang
2025-03-10 14:36 ` [PATCH v3 0/4] pci: qcom: Add QCS615 PCIe support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174159500913.3380799.14221924313975247180.robh@kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_ziyuzhan@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox