From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: lpieralisi@kernel.org, kwilczynski@kernel.org,
Haotian Zhang <vulab@iscas.ac.cn>
Cc: robh@kernel.org, bhelgaas@google.com, michal.simek@amd.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] PCI: xilinx: Fix INTx IRQ domain leak in error paths
Date: Tue, 23 Dec 2025 17:59:54 +0530 [thread overview]
Message-ID: <176649299472.522673.6050154108234112363.b4-ty@kernel.org> (raw)
In-Reply-To: <20251219021615.965-1-vulab@iscas.ac.cn>
On Fri, 19 Dec 2025 10:16:15 +0800, Haotian Zhang wrote:
> In xilinx_pcie_init_irq_domain(), if xilinx_allocate_msi_domains()
> fails after pcie->leg_domain has been successfully created via
> irq_domain_create_linear(), the function returns directly without
> cleaning up the allocated IRQ domain, resulting in a resource leak.
> In xilinx_free_msi_domains(), pcie->leg_domain is also neglected.
>
> Add irq_domain_remove() call in the error path to properly release the
> IRQ domain before returning the error. Rename xilinx_free_msi_domains()
> to xilinx_free_irq_domains() and add the release of pcie->leg_domain
> in the function.
>
> [...]
Applied, thanks!
[1/1] PCI: xilinx: Fix INTx IRQ domain leak in error paths
commit: f42b3c053b1554d66af6fe45bb1ef357464c0456
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
prev parent reply other threads:[~2025-12-23 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 3:33 [PATCH] PCI: xilinx: Fix INTx IRQ domain leak when MSI allocation fails Haotian Zhang
2025-12-18 8:11 ` Manivannan Sadhasivam
2025-12-18 10:23 ` [PATCH v2] " Haotian Zhang
2025-12-18 13:14 ` Manivannan Sadhasivam
2025-12-19 2:16 ` [PATCH v3] PCI: xilinx: Fix INTx IRQ domain leak in error paths Haotian Zhang
2025-12-23 12:29 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176649299472.522673.6050154108234112363.b4-ty@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox