From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: "Lucas Stach" <l.stach@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
devicetree@vger.kernel.org,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
linux-kernel@vger.kernel.org,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Sherry Sun" <sherry.sun@nxp.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio
Date: Fri, 13 Mar 2026 19:38:58 -0500 [thread overview]
Message-ID: <177344873783.3740802.16889031626294728182.robh@kernel.org> (raw)
In-Reply-To: <20260312184344.42337-3-krzysztof.kozlowski@oss.qualcomm.com>
On Thu, 12 Mar 2026 19:43:45 +0100, Krzysztof Kozlowski wrote:
> The binding references snps,dw-pcie-common.yaml which already deprecates
> "reset-gpio", however mentioning this property here lacks this mark thus
> code is confusing and suggests property is not deprecated.
>
> OTOH, the property cannot be removed from this schema, because it is an
> ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible
> map between compatibles, "reset-gpio" and "reset-gpio-active-high"
> properties.
>
> This creates code and binding which is not obvious to follow, so rewrite
> it and be more explicit about:
> 1. Deprecation of "reset-gpio",
> 2. Relation that "reset-gpio-active-high" is used only for that property
> and not proper "reset-gpios".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Cc: Sherry Sun <sherry.sun@nxp.com>
>
> Changes in v2:
> 1. Rewrite the commit completely after Sherry Sun comments - keep the
> property, but add "not" clause to forbid usavge of
> "reset-gpio-active-high" and "reset-gpios".
> 2. Because of above not adding Richard's ack.
>
> v1:
> https://lore.kernel.org/r/20260311154955.145120-3-krzysztof.kozlowski@oss.qualcomm.com
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
prev parent reply other threads:[~2026-03-14 0:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 18:43 [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio Krzysztof Kozlowski
2026-03-12 18:43 ` [PATCH v2 2/2] dt-bindings: PCI: snps,dw-pcie: Drop deprecated reset-gpio Krzysztof Kozlowski
2026-03-14 0:42 ` Rob Herring
2026-03-13 2:27 ` [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio Sherry Sun
2026-03-13 7:34 ` Krzysztof Kozlowski
2026-03-13 8:30 ` Sherry Sun
2026-03-14 0:38 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177344873783.3740802.16889031626294728182.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kwilczynski@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox