Re: firmware-iwlwifi: Wireless AC 7265 lacks D3cold support

["Limonciello, Mario" <mario.limonciello@amd.com>]

On 8/14/2023 1:14 PM, Juno Computers USA wrote:
> Hi, I have never filed from Kernel Buzilla before. Any chance you can 
> send me a link?
> 

Here you go.

https://bugzilla.kernel.org/

Pick "drivers" then "pci" for your bug.

In the CC list you can add my email and Bjorn's email.

> On Aug 14 2023, at 2:02 pm, Limonciello, Mario 
> <mario.limonciello@amd.com> wrote:
> 
> 
> 
>     On 8/14/2023 12:57 PM, Juno Computers USA wrote:
>      > Please check the link below. These are with pcie_port_pm=off.
>      >
>      > https://pastebin.com/aXbBHf3w <https://pastebin.com/aXbBHf3w>
>      > https://pastebin.com/xzdGbtuG <https://pastebin.com/xzdGbtuG>
>      >
>     https://github.com/junocomp/debian-juno-tablet/blob/main/dsdt/tab2/dsdt.dsl <https://github.com/junocomp/debian-juno-tablet/blob/main/dsdt/tab2/dsdt.dsl>
>      > /sys/firmware/acpi/tables$ ls
>      > APIC  data  DBGP  DSDT     FACP  FIDT  HPET  MCFG  PRAM   SSDT10
>      > SSDT12  SSDT3  SSDT5  SSDT7  SSDT9  WSMT BGRT  DBG2  DMAR  dynamic
>      > FACS  FPDT  LPIT  NHLT  SSDT1  SSDT11  SSDT2   SSDT4  SSDT6 
>     SSDT8  TPM2
>      >
>      > Please let em know if you need any more log files.
> 
>     I need to see a full acpidump, it's not predictable which SSDT contains
>     the LPS0 support, and I want to be able to also cross reference the MADT
>     (APIC).
> 
>     Lastly can you please add these all as attachments to a kernel bugzilla?
>     I worry that pastebin is ephemeral and if we're going to need to link to
>     your issue in any way we want somewhere that we know will still be here
>     in 10 years when someone cross references a commit message.
> 
>      > On Aug 14 2023, at 12:58 pm, Limonciello, Mario
>      > <mario.limonciello@amd.com> wrote:
>      >
>      >
>      >
>      > On 8/14/2023 11:56 AM, Juno Computers USA wrote:
>      > > Hi,
>      > >
>      > > I can provide some logs. Should I do it with pcie_port_pm=off or
>      > without?
>      > >
>      >
>      > You could do it with both, just make it clear when you add the
>      > attachment description to the kernel bugzilla which logs are which.
>      >
>      > Also; if you try my patch series please make sure you test
>     without that
>      > parameter and indicate which logs contain it.
>      >
>      > > On Aug 14 2023, at 12:41 pm, Limonciello, Mario
>      > > <mario.limonciello@amd.com> wrote:
>      > >
>      > >
>      > >
>      > > On 8/14/2023 11:35 AM, Bjorn Helgaas wrote:
>      > > > [+cc Mario, linux-pm]
>      > > >
>      > > > On Sun, Aug 13, 2023 at 03:33:21PM +0000, Greenman, Gregory
>     wrote:
>      > > >> On Fri, 2023-08-11 at 15:34 -0400, Juno Computers USA wrote:
>      > > >>> Any updates on this?
>      > > >
>      > > > D3cold support has been a problem area, and there are some
>      > changes in
>      > > > progress [1] that could be related.
>      > >
>      > > Yeah; no harm in at least trying this series. I'd love another data
>      > > point with it.
>      > >
>      > > >
>      > > > Could you possibly collect the complete dmesg logs (with a recent
>      > > > upstream kernel, e.g., v6.4, if possible)? And the output of
>      > > > "sudo lspci -vv"? And the contents of /sys/firmware/acpi/tables/?
>      > > > You can attach them to the Debian bug report if that's
>      > convenient for
>      > > > you.
>      > > >
>      > >
>      > > Yes this could be related but it will come down to
>      > > 1) Whether the root ports are considered power manageable.
>      > > 2) The system uses S0ix or not.
>      > >
>      > > whether the series could help as it stands today.
>      > >
>      > > Please CC me into any kernel bugzilla that you open against a
>      > mainline
>      > > or stable kernel and can capture the lspci output, the dmesg and
>      > > acpidump and I'll look at it.
>      > >
>      > > > Bjorn
>      > > >
>      > > > [1]
>      > >
>      >
>     https://lore.kernel.org/r/20230809185453.40916-1-mario.limonciello@amd.com
>      > >
>      > > BTW - Bjorn, can I have comments on the last patch in this
>     series? I
>      > > have fixes ready locally for everything in the earlier patches
>      > that Andy
>      > > gave feedback but I was hoping for some feedback on the very last
>      > patch
>      > > before I sent out a v12.
>      > >
>      > > Thanks!
>      > >
>      > > >
>      > > >>> On Aug 3 2023, at 8:01 am, Juno Computers USA
>      > > <usa@junocomputers.com> wrote:
>      > > >>>> Dear Maintainer,
>      > > >>>>
>      > > >>>> If D3Cold is enabled from BIOS the tablet boots without Wifi.
>      > > >>>> The only two ways to enable wifi support is either by
>     disabling
>      > > >>>> D3Cold from BIOS (not ideal) or adding pcie_port_pm=off to
>     grub
>      > > >>>>
>      > > >>>> [   12.681303] iwlwifi 0000:01:00.0: Detected Intel(R) Dual
>      > > Band Wireless AC 7265, REV=0x210
>      > > >>>>
>      > > >>>> This is needed for our new Juno Tab 2
>      > > >>>>
>      > > >>>> https://junocomputers.com/us/product/juno-tab-2/
>      > > >>>>
>      > > >>>> I also filed this under Debian bug-tracker.
>      > > >>>>
>      > > >>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036633
>      > > >>>> Thanks,
>      > > >>>>
>      > > >>>> Giovanni Caligaris
>      > > >>>> Juno Computers USA
>      > > >>>> P: (215) 509-5472
>      > > >>>> W: https://junocomputers.com/us
>      > > >>
>      > > >> This device is very old and actually already EOL, so I'll not be
>      > > >> able to get any support for this internally. D3 works fine
>      > with this
>      > > >> NIC on standard, off the shelf laptops, so I'd guess that the
>      > probem
>      > > >> could be rooted in the tablets' PCIe hardware or maybe the BIOS
>      > > >> itself.
>      > >
>      >
>