From: Hanjun Guo <guohanjun@huawei.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>,
"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
Cc: <linux-cxl@vger.kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
<linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 3/6 v7] acpi/ghes: Make GHES select ACPI_APEI_PCIEAER
Date: Fri, 21 Nov 2025 10:12:11 +0800 [thread overview]
Message-ID: <19155ced-8702-71f9-6eba-4dbfdc7c88ad@huawei.com> (raw)
In-Reply-To: <20251111154220.00004767@huawei.com>
On 2025/11/11 23:42, Jonathan Cameron wrote:
> On Tue, 4 Nov 2025 19:22:34 +0100
> "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com> wrote:
>
>> GHES handles the PCI Express Error Section and also the Compute Express
>> Link (CXL) Protocol Error Section. Two of its functions depend on the
>> APEI PCIe AER logging/recovering support (ACPI_APEI_PCIEAER).
>>
>> Make GHES select ACPI_APEI_PCIEAER and remove the conditional
>> compilation from the body of two static functions that handle the CPER
>> Error Sections mentioned above.
>
> Hi Fabio,
>
> I'm not seeing a justification here for the change and there may be
> APEI platforms without PCI support. So is this just to simplify things or
> is there a functional reason that it is necessary?
I have the same worry, embedded system with ACPI support may don't have
PCI. And for APEI, AER is one of the error type and optional.
Thanks
Hanjun
next prev parent reply other threads:[~2025-11-21 2:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 18:22 [PATCH 0/6 v7] Make ELOG and GHES log and trace consistently Fabio M. De Francesco
2025-11-04 18:22 ` [PATCH 1/6 v7] ACPI: extlog: Trace CPER Non-standard Section Body Fabio M. De Francesco
2025-11-04 18:22 ` [PATCH 2/6 v7] ACPI: extlog: Trace CPER PCI Express Error Section Fabio M. De Francesco
2025-11-04 18:22 ` [PATCH 3/6 v7] acpi/ghes: Make GHES select ACPI_APEI_PCIEAER Fabio M. De Francesco
2025-11-11 15:42 ` Jonathan Cameron
2025-11-21 2:12 ` Hanjun Guo [this message]
2025-11-04 18:22 ` [PATCH 4/6 v7] acpi/ghes: Add helper for CXL protocol errors checks Fabio M. De Francesco
2025-11-07 18:30 ` Dave Jiang
2025-11-11 15:43 ` Jonathan Cameron
2025-11-21 2:16 ` Hanjun Guo
2025-11-04 18:22 ` [PATCH 5/6 v7] acpi/ghes: Add helper to copy CXL protocol error info to work struct Fabio M. De Francesco
2025-11-07 18:31 ` Dave Jiang
2025-11-21 2:22 ` Hanjun Guo
2025-11-04 18:22 ` [PATCH 6/6 v7] ACPI: extlog: Trace CPER CXL Protocol Error Section Fabio M. De Francesco
2025-11-07 19:59 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19155ced-8702-71f9-6eba-4dbfdc7c88ad@huawei.com \
--to=guohanjun@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mchehab@kernel.org \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox