From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: David Daney <ddaney.cavm@gmail.com>,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
"Sean O. Stalley" <sean.stalley@intel.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs.
Date: Tue, 29 Sep 2015 09:42:48 +0200 [thread overview]
Message-ID: <1981236.3bSkWiA8PH@wuerfel> (raw)
In-Reply-To: <1443488184-12633-1-git-send-email-ddaney.cavm@gmail.com>
On Monday 28 September 2015 17:56:24 David Daney wrote:
> From: David Daney <david.daney@cavium.com>
>
> Early versions of the Cavium Thunder CN88XX processor are missing
> Enhanced Allocation (EA) capabilities for the fixed BAR addresses used
> by the on-SoC hardware blocks.
>
> Add config access functions that synthesize the missing EA
> capabilities for versions that are missing that information. Since
> this is a little hacky, gate the inclusion of the code with a new
> Kconfig variable.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
>
> As suggested by Bjorn Helgaas... It is RFC at this point, but this is
> working well for me.
I don't have an opinion on the way you implement the config space
accessors, but it seems that the overall amount of code is comparable
to the normal pci-host-generic driver without this, and it is not
really generic at all.
I think because of this, it makes more sense to have a separate top-level
driver for this and not reuse the pci-host-generic implementation here.
Arnd
next prev parent reply other threads:[~2015-09-29 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 0:56 [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs David Daney
2015-09-29 7:42 ` Arnd Bergmann [this message]
2015-09-29 16:03 ` David Daney
2015-11-25 17:06 ` Bjorn Helgaas
2015-11-25 17:26 ` David Daney
2015-11-25 19:52 ` Arnd Bergmann
2015-11-25 20:05 ` David Daney
2015-11-25 20:09 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1981236.3bSkWiA8PH@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=sean.stalley@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).