From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 1/3] iommu: of: Fix check for returning EPROBE_DEFER To: Bjorn Helgaas References: <1495020609-13397-1-git-send-email-sricharan@codeaurora.org> <20170517170430.GD31462@bhelgaas-glaptop.roam.corp.google.com> From: Sricharan R Message-ID: <1c306cf1-f7fb-87b1-1fef-3b08aea04560@codeaurora.org> Date: Thu, 18 May 2017 14:33:57 +0530 MIME-Version: 1.0 In-Reply-To: <20170517170430.GD31462@bhelgaas-glaptop.roam.corp.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, okaya@codeaurora.org, frowand.list@gmail.com, m.szyprowski@samsung.com, linux-arch@vger.kernel.org, lorenzo.pieralisi@arm.com, tn@semihalf.com, joro@8bytes.org, magnus.damm@gmail.com, linux-acpi@vger.kernel.org, geert@linux-m68k.org, linux-pci@vger.kernel.org, lenb@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, j.neuschaefer@gmx.net, robh+dt@kernel.org, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, hanjun.guo@linaro.org, sudeep.holla@arm.com, robin.murphy@arm.com Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Bjorn, On 5/17/2017 10:34 PM, Bjorn Helgaas wrote: > On Wed, May 17, 2017 at 05:00:07PM +0530, Sricharan R wrote: >> Now with iommu probe deferral, we return -EPROBE_DEFER >> for master's that are connected to an iommu which is not > > s/master's/masters/ > > s/iommu/IOMMU/ in your English text (changelogs and comments). That seems > to be the convention, based on "git log drivers/iommu/of_iommu.c" > ok, will correct those. Regards, Sricharan >> probed yet, but going to get probed, so that we can attach >> the correct dma_ops. So while trying to defer the probe of >> the master, check if the of_iommu node that it is connected >> to is marked in DT as 'status=disabled', then the iommu is never >> is going to get probed. So simply return NULL and let the master >> work without an iommu. >> >> Fixes: 7b07cbefb68d ("iommu: of: Handle IOMMU lookup failure with deferred probing or error") >> Signed-off-by: Sricharan R >> Reported-by: Geert Uytterhoeven >> Tested-by: Will Deacon >> Tested-by: Magnus Damn >> Acked-by: Will Deacon >> --- >> drivers/iommu/of_iommu.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c >> index 9f44ee8..e6e9bec 100644 >> --- a/drivers/iommu/of_iommu.c >> +++ b/drivers/iommu/of_iommu.c >> @@ -118,6 +118,7 @@ static bool of_iommu_driver_present(struct device_node *np) >> >> ops = iommu_ops_from_fwnode(fwnode); >> if ((ops && !ops->of_xlate) || >> + !of_device_is_available(iommu_spec->np) || >> (!ops && !of_iommu_driver_present(iommu_spec->np))) >> return NULL; >> >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel