From: Greg Ungerer <gerg@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] m68k/pci: Drop useless pcibios_setup()
Date: Wed, 19 Jul 2023 14:37:09 +1000 [thread overview]
Message-ID: <1c657304-7fb6-1f03-9fa6-7225fc14c28d@kernel.org> (raw)
In-Reply-To: <20230718204229.493669-1-helgaas@kernel.org>
Hi Bjorn,
On 19/7/23 06:42, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The PCI core supplies a weak pcibios_setup() implementation that is
> identical to the m68k implementation. Remove the m68k version since it is
> unnecessary.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Thanks. Seeing as this is related to the ColdFire parts I'll take this through
the m68knommu git tree. Applied to the for-next branch.
Regards
Greg
> ---
> arch/m68k/kernel/pcibios.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
> index b0e110d3d2e6..9504eb19d73a 100644
> --- a/arch/m68k/kernel/pcibios.c
> +++ b/arch/m68k/kernel/pcibios.c
> @@ -92,9 +92,3 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> pci_write_config_byte(dev, PCI_LATENCY_TIMER, 32);
> }
> }
> -
> -char *pcibios_setup(char *str)
> -{
> - return str;
> -}
> -
prev parent reply other threads:[~2023-07-19 4:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 20:42 [PATCH] m68k/pci: Drop useless pcibios_setup() Bjorn Helgaas
2023-07-19 4:37 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c657304-7fb6-1f03-9fa6-7225fc14c28d@kernel.org \
--to=gerg@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).