From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA086326D60 for ; Wed, 10 Sep 2025 14:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757514815; cv=none; b=mLrHsI0p0pDD52Vs//ZEQCdvIdanDnPakKnIPN5KVmlgMdZVNfpPRAsE+5ExrBVLDg/Df9G+TmkOqFwTYxUCXIqmA1yuMCau+5w+MXJPalXSIOdLHIqhRg1gXV5WoDweF7GXTwbnTyTGLzfoJ8/b4yGkvYShI8j6YOsHlrcOzfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757514815; c=relaxed/simple; bh=ZV32YFX/qWVrf3r82W+gLBIuV4AqRThwbUbsXnzL4mw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CrmreOkNsOAsrCaF2AJZB2YzdtOX8Mr9eipjbe4ye20LaEJ1j4iZwAO14QLtgjjdakBny2fGjl+WA2sLO094qhkjov37MMV1hGJ/qA8tnWTCqTT/9WM95dJaS5ctwNcXfq3fa2Z04sWJ2nQzITLcsiEPm0qxvYj2E30Vp4+0Vn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RIPdlXBr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=aPbQTK0k; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=DHnj4RBh; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=C7dAZMDa; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RIPdlXBr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="aPbQTK0k"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DHnj4RBh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="C7dAZMDa" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 233D238494; Wed, 10 Sep 2025 14:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757514811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ikw4jiiY7S2fYJkezEQT0dSKUI9SI40oygtMNCfxpuY=; b=RIPdlXBrTxjXDImJOqMu941nKRyca4jrgtdxxGgeKq7uqpJSdBApyzRXVLXdgy/7ZEqr1P AN4tCnGJFx8uVARhxGEKqac6S1eZgOaxQaJYJu4cYpWhBRHw0TxFsRViVGgXoTT73rddM2 9YhHHBble+pFBjBKujvL9ujy1w5LjT8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757514811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ikw4jiiY7S2fYJkezEQT0dSKUI9SI40oygtMNCfxpuY=; b=aPbQTK0kQEB7A6/j4s9KMmKLPEoUkJ58VIYPXEqM5sUqMs/bit9Q4Qj6RtSnOlIs0tlwZM avgDvl5Bbs5TfKBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757514810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ikw4jiiY7S2fYJkezEQT0dSKUI9SI40oygtMNCfxpuY=; b=DHnj4RBhlBqEd3erIu7MtYqpX4kphWIwb2LfRzXVIROmeoF2P3IoVEONcVd1wBbBpqIG5z 7jodtT3gMqzcK5QjUgrsFefGvWdB1XKUu0VMInO+SHIRi9yjY80Kx/gwDge3j0Ffct9awE CR/v4Oi/+JZ/q9uIL8hIGpzlksijLg4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757514810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ikw4jiiY7S2fYJkezEQT0dSKUI9SI40oygtMNCfxpuY=; b=C7dAZMDaqeS1MOqgEIkTxs7C4sDK1WKHr8ZO8D4aJny4d8u68PpOx2r7OR/38oJ6PRdzMm OewhkkesF1EjecCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B40D313310; Wed, 10 Sep 2025 14:33:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cRuTKjmMwWguJQAAD6G6ig (envelope-from ); Wed, 10 Sep 2025 14:33:29 +0000 Message-ID: <1dd1dfe2-8005-4d02-8032-46c31c41423e@suse.de> Date: Wed, 10 Sep 2025 16:33:29 +0200 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with a screen info check To: "Mario Limonciello (AMD)" , David Airlie , Bjorn Helgaas Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Simona Vetter , Maarten Lankhorst , Maxime Ripard , "open list:DRM DRIVERS" , open list , "open list:PCI SUBSYSTEM" , Daniel Dadap References: <20250811162606.587759-1-superm1@kernel.org> <20250811162606.587759-3-superm1@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20250811162606.587759-3-superm1@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[kernel.org,gmail.com,google.com]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Level: X-Spam-Score: -4.30 Am 11.08.25 um 18:26 schrieb Mario Limonciello (AMD): > vga_is_firmware_default() checks firmware resources to find the owner > framebuffer resources to find the firmware PCI device. This is an > open coded implementation of screen_info_pci_dev(). Switch to using > screen_info_pci_dev() instead. > > Acked-by: Bjorn Helgaas > Suggested-by: Thomas Zimmermann > Signed-off-by: Mario Limonciello (AMD) Reviewed-by: Thomas Zimmermann > --- > v10: > * Rebase on 6.17-rc1 > --- > drivers/pci/vgaarb.c | 31 +++++-------------------------- > 1 file changed, 5 insertions(+), 26 deletions(-) > > diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c > index 78748e8d2dbae..b58f94ee48916 100644 > --- a/drivers/pci/vgaarb.c > +++ b/drivers/pci/vgaarb.c > @@ -556,34 +556,13 @@ EXPORT_SYMBOL(vga_put); > > static bool vga_is_firmware_default(struct pci_dev *pdev) > { > -#if defined(CONFIG_X86) > - u64 base = screen_info.lfb_base; > - u64 size = screen_info.lfb_size; > - struct resource *r; > - u64 limit; > +#ifdef CONFIG_SCREEN_INFO > + struct screen_info *si = &screen_info; > > - /* Select the device owning the boot framebuffer if there is one */ > - > - if (screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE) > - base |= (u64)screen_info.ext_lfb_base << 32; > - > - limit = base + size; > - > - /* Does firmware framebuffer belong to us? */ > - pci_dev_for_each_resource(pdev, r) { > - if (resource_type(r) != IORESOURCE_MEM) > - continue; > - > - if (!r->start || !r->end) > - continue; > - > - if (base < r->start || limit >= r->end) > - continue; > - > - return true; > - } > -#endif > + return pdev == screen_info_pci_dev(si); > +#else > return false; > +#endif > } > > static bool vga_arb_integrated_gpu(struct device *dev) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)