From: "Michael S. Tsirkin" <mst@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Paul Mundt <lethal@linux-sh.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH-RFC 1/2 v2] tile: don't panic on iomap
Date: Wed, 30 Nov 2011 11:08:40 +0200 [thread overview]
Message-ID: <20111130090839.GA20062@redhat.com> (raw)
In-Reply-To: <a3bc9cb56040258dabc7b466ea217f4515b68b7d.1322592495.git.mst@redhat.com>
I think panic on iomap is there just for debugging.
If we return NULL instead, the generic pci_iomap will
do the same thing as the custom one that tile currently has
(that is, return NULL on an IO BAR)
so tile won't need to roll its own anymore.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Note: the other patch in the series is unchanged.
Changes from v1:
- tweaked pr_info message
arch/tile/include/asm/io.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h
index c9ea165..d2152de 100644
--- a/arch/tile/include/asm/io.h
+++ b/arch/tile/include/asm/io.h
@@ -204,7 +204,8 @@ static inline long ioport_panic(void)
static inline void __iomem *ioport_map(unsigned long port, unsigned int len)
{
- return (void __iomem *) ioport_panic();
+ pr_info("ioport_map: mapping IO resources is unsupported on tile.\n");
+ return NULL;
}
static inline void ioport_unmap(void __iomem *addr)
--
1.7.5.53.gc233e
next prev parent reply other threads:[~2011-11-30 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 18:54 [PATCH-RFC 0/2] tile: switch to generic pci_iomap Michael S. Tsirkin
2011-11-29 18:54 ` [PATCH-RFC 1/2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 21:04 ` Bjorn Helgaas
2011-11-30 7:04 ` Michael S. Tsirkin
2011-11-29 22:05 ` Arnd Bergmann
2011-11-30 7:13 ` Michael S. Tsirkin
2011-11-30 9:09 ` Arnd Bergmann
2011-11-30 11:59 ` Michael S. Tsirkin
2011-11-30 14:04 ` Arnd Bergmann
2011-11-30 14:31 ` Michael S. Tsirkin
2011-11-30 15:49 ` Arnd Bergmann
2011-11-30 15:59 ` Michael S. Tsirkin
2011-11-30 18:32 ` Arnd Bergmann
2011-12-01 17:59 ` [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI Chris Metcalf
2011-12-01 18:44 ` Tejun Heo
2011-12-01 18:48 ` Chris Metcalf
2011-12-01 22:47 ` Arnd Bergmann
2011-12-02 18:48 ` Chris Metcalf
2011-12-05 15:14 ` Arnd Bergmann
2011-12-05 20:08 ` Chris Metcalf
2011-11-30 9:08 ` Michael S. Tsirkin [this message]
2011-11-29 18:54 ` [PATCH-RFC 2/2] tile: switch to GENERIC_PCI_IOMAP Michael S. Tsirkin
2011-11-30 21:19 ` Chris Metcalf
[not found] <V0IAN#zrMHA.5780@exchange1.tad.internal.tilera.com>
2011-11-30 19:23 ` [PATCH-RFC 1/2 v2] tile: don't panic on iomap Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130090839.GA20062@redhat.com \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).