From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:55134 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437Ab1LASot (ORCPT ); Thu, 1 Dec 2011 13:44:49 -0500 Date: Thu, 1 Dec 2011 10:44:42 -0800 From: Tejun Heo To: Chris Metcalf Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Rolf Eike Beer , Andrew Morton , "Maxin B. John" , "Michael S. Tsirkin" , Lucas De Marchi , Paul Mundt , Jesse Barnes , "David S. Miller" Subject: Re: [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI Message-ID: <20111201184442.GA13173@google.com> References: <201111301404.41544.arnd@arndb.de> <20111130143122.GC21413@redhat.com> <201111301549.57430.arnd@arndb.de> <201112011815.pB1IFGZe004948@farm-0002.internal.tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <201112011815.pB1IFGZe004948@farm-0002.internal.tilera.com> Sender: linux-pci-owner@vger.kernel.org List-ID: Hello, On Thu, Dec 01, 2011 at 12:59:19PM -0500, Chris Metcalf wrote: > The tile architecture does not support IOPORT, but it does support > PCI and IOMEM. We were not specifying NO_IOPORT, though, because it > was causing a couple of functions (pcim_iomap_regions and pcim_iomap_table) > that are needed to not get provided. Moving the #ifdef fixes this > so that those functions and some related ones are now always provided > if CONFIG_PCI is true. > > Signed-off-by: Chris Metcalf Acked-by: Tejun Heo Please feel free to route the change through tile. If not, Andrew, can you please pick this up? Thanks. -- tejun