From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai.lu@oracle.com>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: Only call pci_stop_bus_device() one time for children devices during removing
Date: Mon, 5 Dec 2011 11:38:03 -0800 [thread overview]
Message-ID: <20111205113803.37cc5d4c@jbarnes-desktop> (raw)
In-Reply-To: <4ECC7F6D.6090802@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tue, 22 Nov 2011 21:06:53 -0800
Yinghai Lu <yinghai.lu@oracle.com> wrote:
>
> During debugging pcie hotplug with SRIOV with pcie switch, found
> pci_stop_bus_device() are called several times for some children devices.
>
> Current pci_remove_bus_device() will call pci_stop_bus_device() at first.
> and then use remove_behind_bridge() to call pci_stop_bus_device() for children
> devices. But pci_stop_bus_device() already include depth first to stop children.
> So We can remove unnecessary calling in pci_remove_behind_bridge() for children.
>
> The patch change original pci_remove_bus_device() to __pci_remove_bus_device(), and
> it only do remove work, and new pci_remove_bus_device will call
> pci_stop_bus_device() one time, and then call __pci_remove_bus_device().
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-12-05 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 5:06 [PATCH] PCI: Only call pci_stop_bus_device() one time for children devices during removing Yinghai Lu
2011-12-05 19:38 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205113803.37cc5d4c@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).