From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:33676 "HELO oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755586Ab1LETfb (ORCPT ); Mon, 5 Dec 2011 14:35:31 -0500 Date: Mon, 5 Dec 2011 11:38:03 -0800 From: Jesse Barnes To: Yinghai Lu Cc: Kenji Kaneshige , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH] PCI: Only call pci_stop_bus_device() one time for children devices during removing Message-ID: <20111205113803.37cc5d4c@jbarnes-desktop> In-Reply-To: <4ECC7F6D.6090802@oracle.com> References: <4ECC7F6D.6090802@oracle.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/zOu9lkd8t/.46BhH4gW1vum"; protocol="application/pgp-signature" Sender: linux-pci-owner@vger.kernel.org List-ID: --Sig_/zOu9lkd8t/.46BhH4gW1vum Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 22 Nov 2011 21:06:53 -0800 Yinghai Lu wrote: >=20 > During debugging pcie hotplug with SRIOV with pcie switch, found > pci_stop_bus_device() are called several times for some children devices. >=20 > Current pci_remove_bus_device() will call pci_stop_bus_device() at first. > and then use remove_behind_bridge() to call pci_stop_bus_device() for chi= ldren > devices. But pci_stop_bus_device() already include depth first to stop ch= ildren. > So We can remove unnecessary calling in pci_remove_behind_bridge() for ch= ildren. >=20 > The patch change original pci_remove_bus_device() to __pci_remove_bus_dev= ice(), and > it only do remove work, and new pci_remove_bus_device will call > pci_stop_bus_device() one time, and then call __pci_remove_bus_device(). >=20 > Signed-off-by: Yinghai Lu applied to linux-next, thanks. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/zOu9lkd8t/.46BhH4gW1vum Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJO3R2bAAoJEIEoDkX4Qk9hBz0P/RTnsxsrktzh/K+siypJwG6l ZSHaWzCNoGhBfzuJqJbN2FAsOu4fFjiDCkcXLFtT21/v5tpE/VwJQzArmYTrhnLf IHZ83hWZoDIkbTHzNw0CyljUU7Ejijn9fwJfotngAKzH2s/UjG3CnaTQVVdQ0IL0 jwu8UHxkv9ezWBh2JQ4RvHNG0gFwK2kc+MCNBtJGhUaE9APsIrQihe4XV1vRht69 61duC4sf0466fcRBD0ECCGhk4E4jH1EYVKvJvx1gpE9S13nnj3KsZlw0bZ9iuyCn GsQATRfA215XtYS+KjPjmVLsFxGbPE2ZBvyHMQsHiYOvReTvB/rHN3H2BlDRvgxP 4vMA7S8zY2grln2e6OePfu1RJwGfT+2MgWNyJFUQghy0ePllQm2e37iHbtQmLvgo 1fB6fs41pJs2Vt4LHJXAXh+T/KNAPkWsj/E0hW0nArkOrxpJIBR5LYNNnJ6DTiBn UeIOVank9RiGzgQglkMaUDrqP7OM8oo7wMYpPCdAhAenrno+jz+jP8v91+Vr/Y6t hWgq/fm2ZSmXUXE4gDeaxzIucRmNhGqX/U2yzvsxDlohod+4m6qQ5Z/WAEkKzLDY GBvUUHz8u9mSLp91qSzZDob1VwQRB1GqrZZ4JT/eo+9n80ZooYhe8gYCmgXoPxzO IFpxIfgi+WgANW2o7jsO =tZ0v -----END PGP SIGNATURE----- --Sig_/zOu9lkd8t/.46BhH4gW1vum--