From: Ram Pai <linuxram@us.ibm.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Don Dutile <ddutile@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Nishanth Aravamudan <nacc@us.ibm.com>,
prarit@redhat.com, brking@linux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/1]PCI: defer enablement of SRIOV BARS
Date: Thu, 8 Dec 2011 10:50:39 +0800 [thread overview]
Message-ID: <20111208025039.GH19129@ram-ThinkPad-T61> (raw)
In-Reply-To: <CAE9FiQXOhn2HkqCh3DiSNUw7RwgAAk2Xe62z11AB=L+pcG__Qg@mail.gmail.com>
On Wed, Dec 07, 2011 at 03:11:56PM -0800, Yinghai Lu wrote:
> On Wed, Dec 7, 2011 at 12:23 PM, Don Dutile <ddutile@redhat.com> wrote:
> > why not something more explicit like:
> >
> > for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
> > if ((i >= PCI_IOV_RESOURCES) && (i <= PCI_IOV_RESOURCE_END))
> > continue; /* skip sriov related resources */
> >
> > if (dev->resource[i].flags & flags)
> > bars |= (1 << i);
> > }
I like this approach too. Offcourse the SRIOV skipping has to be one under #ifdef CONFIG_PCI_IOV.
Yinghai/Jesse, do you want to make a patch on top of the current jesse's to-linus
tree or want to revert my patch and apply your fix? If it is the former, do you want me
to make the patch?
RP
next prev parent reply other threads:[~2011-12-08 2:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111006210320.GA14959@us.ibm.com>
[not found] ` <CAErSpo7b_6_AaZXW9XBx5p3-0PZJk-1jeCork__KePdzCS89OA@mail.gmail.com>
[not found] ` <1317970100.29415.305.camel@pasglop>
[not found] ` <CAErSpo58okGsDW4dOK4i0g_RUejkuQa=iw2uQ5HAJJZCwFtsbw@mail.gmail.com>
[not found] ` <20111007232516.GF2980@ram-ThinkPad-T61>
[not found] ` <1318057168.29415.333.camel@pasglop>
[not found] ` <20111008075353.GK2980@ram-ThinkPad-T61>
[not found] ` <1318060793.29415.347.camel@pasglop>
[not found] ` <20111102140325.004b9dad@jbarnes-desktop>
[not found] ` <20111103013014.GB393@ram-ThinkPad-T61>
[not found] ` <20111106023310.GA2383@ram-ThinkPad-T61>
2011-11-11 18:01 ` [RFC PATCH 1/1]PCI: defer enablement of SRIOV BARS Jesse Barnes
2011-11-14 4:33 ` Ram Pai
2011-11-14 4:56 ` Michael Wang
2011-12-05 18:32 ` Jesse Barnes
2011-12-07 8:22 ` Yinghai Lu
2011-12-07 9:25 ` Ram Pai
2011-12-07 19:33 ` Yinghai Lu
2011-12-07 20:23 ` Don Dutile
2011-12-07 20:35 ` Nishanth Aravamudan
2011-12-07 22:34 ` Don Dutile
2011-12-07 23:11 ` Yinghai Lu
2011-12-08 2:50 ` Ram Pai [this message]
2011-12-08 13:53 ` Jesse Barnes
2011-12-08 16:59 ` Yinghai Lu
2011-12-09 10:04 ` [PATCH 1/1 v2]PCI: " Ram Pai
2011-12-08 16:22 ` [RFC PATCH 1/1]PCI: " Don Dutile
[not found] ` <20111106023357.GB2383@ram-ThinkPad-T61>
2011-12-05 18:17 ` [RFC PATCH 1/1] PCI:delay configuration of SRIOV capability Jesse Barnes
2011-12-05 21:25 ` Don Dutile
2011-12-06 7:51 ` Ram Pai
2011-12-06 9:14 ` Don Dutile
2011-12-05 21:37 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208025039.GH19129@ram-ThinkPad-T61 \
--to=linuxram@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=ddutile@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=nacc@us.ibm.com \
--cc=prarit@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).