Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-pci@vger.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: Re: [PATCH][Regression fix] PCI / Hotplug: Always allow acpiphp to handle non-PCIe bridges
Date: Tue, 13 Dec 2011 22:09:04 +0100	[thread overview]
Message-ID: <201112132209.04185.rjw@sisk.pl> (raw)
In-Reply-To: <20111213104220.5cfb78b2@jbarnes-desktop>

On Tuesday, December 13, 2011, Jesse Barnes wrote:
> On Tue, 13 Dec 2011 00:02:28 +0100
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > 
> > Commit 0d52f54e2ef64c189dedc332e680b2eb4a34590a (PCI / ACPI: Make
> > acpiphp ignore root bridges using PCIe native hotplug) added code
> > that made the acpiphp driver completely ignore PCIe root complexes
> > for which the kernel had been granted control of the native PCIe
> > hotplug feature by the BIOS through _OSC.  Unfortunately, however,
> > this was a mistake, because on some systems there were PCI bridges
> > supporting PCI (non-PCIe) hotplug under such root complexes and
> > those bridges should have been handled by acpiphp.
> > 
> > For this reason, revert the changes made by the commit mentioned
> > above and make register_slot() in drivers/pci/hotplug/acpiphp_glue.c
> > avoid registering hotplug slots for PCIe ports that belong to
> > root complexes with native PCIe hotplug enabled (which means that
> > the BIOS has granted the kernel control of this feature for the
> > given root complex).  This is reported to address the original
> > issue fixed by commit 0d52f54e2ef64c189dedc332e680b2eb4a34590a and
> > to work on the system where that commit broke things.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> 
> Applied to my for-linus branch.  I'll probably send to Linus on Thu. or
> so.
> 
> I also rebased the breakage out of linux-next.

Thanks a lot!

Rafael

      reply	other threads:[~2011-12-13 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 23:02 [PATCH][Regression fix] PCI / Hotplug: Always allow acpiphp to handle non-PCIe bridges Rafael J. Wysocki
2011-12-12 23:09 ` Rafael J. Wysocki
2011-12-13 18:42 ` Jesse Barnes
2011-12-13 21:09   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112132209.04185.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox