Re: [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects

[Jesse Barnes <jbarnes@virtuousgeek.org>]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

On Tue, 3 Jan 2012 13:53:05 -0500
Neil Horman <nhorman@tuxdriver.com> wrote:

> On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote:
> > From: Neil Horman <nhorman@tuxdriver.com>
> > Date: Tue,  3 Jan 2012 10:29:54 -0500
> > 
> > > This warning was recently reported to me:
> > 
> > I've hit this too, see:
> > 
> > http://marc.info/?l=linux-kernel&m=132458146927890&w=2
> > 
> > and my analysis at:
> > 
> > http://marc.info/?l=linux-arch&m=132458391128660&w=2
> > 
> Yup, your analysis is correct. Regardless of the why behind msi enablement
> failing, we need to gate the kobject_del/put in free_msi_irqs on successful
> completion of kobject_init_and_add in populate_msi_sysfs.  This patch does that,
> using the parent pointer as a flag.

I applied this to my -next branch; doesn't seem critical to land
immediately.  If you disagree let me know and I'll pull it over to my
for-linus branch instead.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]