From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: David Miller <davem@davemloft.net>
Cc: nhorman@tuxdriver.com, linux-kernel@vger.kernel.org,
bhelgaas@google.com, gregkh@suse.de, linux-pci@vger.kernel.org
Subject: Re: [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects
Date: Wed, 4 Jan 2012 12:02:48 -0800 [thread overview]
Message-ID: <20120104120248.4f4747bf@jbarnes-desktop> (raw)
In-Reply-To: <20120104.145619.1728971973635198635.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]
On Wed, 04 Jan 2012 14:56:19 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Wed, 4 Jan 2012 14:51:34 -0500
>
> > On Wed, Jan 04, 2012 at 09:19:52AM -0800, Jesse Barnes wrote:
> >> On Tue, 3 Jan 2012 13:53:05 -0500
> >> Neil Horman <nhorman@tuxdriver.com> wrote:
> >>
> >> > On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote:
> >> > > From: Neil Horman <nhorman@tuxdriver.com>
> >> > > Date: Tue, 3 Jan 2012 10:29:54 -0500
> >> > >
> >> > > > This warning was recently reported to me:
> >> > >
> >> > > I've hit this too, see:
> >> > >
> >> > > http://marc.info/?l=linux-kernel&m=132458146927890&w=2
> >> > >
> >> > > and my analysis at:
> >> > >
> >> > > http://marc.info/?l=linux-arch&m=132458391128660&w=2
> >> > >
> >> > Yup, your analysis is correct. Regardless of the why behind msi enablement
> >> > failing, we need to gate the kobject_del/put in free_msi_irqs on successful
> >> > completion of kobject_init_and_add in populate_msi_sysfs. This patch does that,
> >> > using the parent pointer as a flag.
> >>
> >> I applied this to my -next branch; doesn't seem critical to land
> >> immediately. If you disagree let me know and I'll pull it over to my
> >> for-linus branch instead.
> >>
> >> Thanks,
> > I'm ok with it waiting, but I'll defer to Dave and others who have seen it
> > occur. It sounds like its alot of log noise.
>
> The bug only exists in the PCI -next code I thought.
Oh yeah, looks like it. Lost track of my -next vs master branches
there...
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-04 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 15:29 [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects Neil Horman
2012-01-03 18:05 ` David Miller
2012-01-03 18:53 ` Neil Horman
2012-01-04 17:19 ` Jesse Barnes
2012-01-04 19:51 ` Neil Horman
2012-01-04 19:56 ` David Miller
2012-01-04 20:02 ` Jesse Barnes [this message]
2012-01-04 21:18 ` Josh Boyer
2012-01-04 21:25 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104120248.4f4747bf@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).