From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] PCI fixes
Date: Fri, 6 Jan 2012 12:46:49 -0800 [thread overview]
Message-ID: <20120106124649.146001d6@jbarnes-desktop> (raw)
In-Reply-To: <CA+55aFz7j8ipEn7e0dGnrG4dskyRiBOx0-ExAx3qnH_cR5mLQw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
On Sun, 18 Dec 2011 14:14:13 -0800
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Sat, Dec 17, 2011 at 9:52 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >
> > Crap, and after you guys spent so long coming up with a clean version.
> >
> > Linus, can you just apply this one on top? I think it's the one Yinghai and Ram agreed to.
>
> Ok, applied, but I have to say that I hate it.
>
> Why don't we just move the stupid iov indexes to the end, and then
> ignore them by not counting through them in
> __pci_enable_device_flags()? So the regular PCI code would always walk
> through the resources 0 .. PCI_BRIDGE_RESOURCES_END or something. And
> then the magic IOV code could look at its own ones that the generic
> code apparently doesn't even want to know about.
>
> Hmm?
There was some talk awhile back of pulling the SR-IOV resources out of
the pci_dev resource array (adding a separate member to track them only
if CONFIG_PCI_IOV is enabled), that would probably be the way to go.
Then fix up whatever resource walking code that cares about IOV BARs
(there isn't much I think).
Any thoughts Yinghai?
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-06 20:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 17:29 [git pull] PCI fixes Jesse Barnes
2011-12-18 2:33 ` Yinghai Lu
2011-12-18 5:52 ` Jesse Barnes
2011-12-18 22:14 ` Linus Torvalds
2012-01-06 20:46 ` Jesse Barnes [this message]
2012-01-07 1:14 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2012-03-05 21:49 Jesse Barnes
2012-02-17 17:24 Jesse Barnes
2011-11-23 22:44 Jesse Barnes
2011-11-23 23:02 ` Linus Torvalds
2011-12-05 19:22 ` Jesse Barnes
2011-12-06 8:08 ` Kenji Kaneshige
2011-12-06 16:14 ` Linus Torvalds
2011-12-06 22:36 ` Yinghai Lu
2011-12-07 8:18 ` Kenji Kaneshige
2011-12-07 19:20 ` Yinghai Lu
2011-12-07 7:58 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106124649.146001d6@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).