From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:48112 "HELO oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759112Ab2AFUq4 (ORCPT ); Fri, 6 Jan 2012 15:46:56 -0500 Date: Fri, 6 Jan 2012 12:46:49 -0800 From: Jesse Barnes To: Linus Torvalds Cc: Yinghai Lu , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [git pull] PCI fixes Message-ID: <20120106124649.146001d6@jbarnes-desktop> In-Reply-To: References: <20111217092935.2c2e075e@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/FpCkH/x/=WSxyVX_t5/_6UZ"; protocol="application/pgp-signature" Sender: linux-pci-owner@vger.kernel.org List-ID: --Sig_/FpCkH/x/=WSxyVX_t5/_6UZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 18 Dec 2011 14:14:13 -0800 Linus Torvalds wrote: > On Sat, Dec 17, 2011 at 9:52 PM, Jesse Barnes = wrote: > > > > Crap, and after you guys spent so long coming up with a clean version. > > > > Linus, can you just apply this one on top? I think it's the one Yinghai= and Ram agreed to. >=20 > Ok, applied, but I have to say that I hate it. >=20 > Why don't we just move the stupid iov indexes to the end, and then > ignore them by not counting through them in > __pci_enable_device_flags()? So the regular PCI code would always walk > through the resources 0 .. PCI_BRIDGE_RESOURCES_END or something. And > then the magic IOV code could look at its own ones that the generic > code apparently doesn't even want to know about. >=20 > Hmm? There was some talk awhile back of pulling the SR-IOV resources out of the pci_dev resource array (adding a separate member to track them only if CONFIG_PCI_IOV is enabled), that would probably be the way to go. Then fix up whatever resource walking code that cares about IOV BARs (there isn't much I think). Any thoughts Yinghai? Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/FpCkH/x/=WSxyVX_t5/_6UZ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJPB125AAoJEIEoDkX4Qk9hAw4P/1f9b22hEWv/dlQG+sFO3vga j+g3S9aK0RWYwtc+GXgDYZIzqpwgCSHcCptpQKJlmI3uvTPX6v7B1KjU/HHLPyJ9 8RdtFAeP+iVo8dQWrked1BVdQRMh39Tc8k2byyBr7t5FLyQh7Uu4BLDNxw7WmSPK UALkRUdtuJcnvtI9hnDFG+MeHZaf6nIrwksQwKX5MzXBh1YflgfjuL6lwhtrEgxq LO2yzPDzbRAYAt0Yo+2WIwYpk4sA5Yp52k0PXFR+IA6saY+ZvsSfeqHSnWBTu2lq gu9KqoZIL4xtzycwS8FWVVPRSCvZ1PBIuIsEbWUQJ1mGtDsJHopi3B4CUsRPmhi0 TbhWwPltbG4dU7oKleHW0u3QBxzxBFwxBCZKNdXGyAcUXzNW0u39AddgHk+ssrBn h0wUHtfurtfw6hlFYxsc3sDUVsmpXfvNV2LYCPhkvTfdPnLB1lFdwX2ZPtf1/NOe 8JNskSHfEQ3w1Vg8CbAvw+Yser//IiI6gPwgG1mlo/tE3eSymLj8ddaaBkyPi08U TI8VOKiPtq5LDgy0/P9EFkfz+332bvlRFL+/ZZexlmmgNxkh0cOqQleU6DHSO89n ZIvCnaN7HOeffPa6fOpwyPGwsaAmIrgsqIOTKe6TX4DQMtTvwWpBgCg889c++xS8 YyKxd7C76UG36mZv3UU8 =BNoN -----END PGP SIGNATURE----- --Sig_/FpCkH/x/=WSxyVX_t5/_6UZ--