From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-pci@vger.kernel.org, linux-pcmcia@lists.infradead.org,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH resend] Clean up new_id and remove_id sysfs attribute routines
Date: Tue, 24 Jan 2012 16:33:13 -0800 [thread overview]
Message-ID: <20120125003313.GA15617@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1201241433200.1200-100000@iolanthe.rowland.org>
On Tue, Jan 24, 2012 at 02:35:13PM -0500, Alan Stern wrote:
> This patch (as1514) cleans up some places where new_id and remove_id
> sysfs attributes are created and deleted. Handling both attributes in
> a single routine rather than a pair of routines makes the code
> smaller. It also prevents certain kinds of errors, like one we
> currently have in the USB subsystem: The removeid attribute is often
> created even when newid isn't (because the driver's no_dynamid_id flag
> is set).
>
> In the case of the PCMCIA subsystem, the newid attribute is created
> but never explicitly deleted. The patch adds a deletion routine.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> CC: Dominik Brodowski <linux@dominikbrodowski.net>
Jesse and Dominik, any objection for me to take this through my tree?
thanks,
greg k-h
next prev parent reply other threads:[~2012-01-25 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 19:35 [PATCH resend] Clean up new_id and remove_id sysfs attribute routines Alan Stern
2012-01-25 0:33 ` Greg KH [this message]
2012-01-25 0:59 ` Jesse Barnes
2012-01-25 19:32 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125003313.GA15617@kroah.com \
--to=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).