From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60482 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754969Ab2AYAdZ (ORCPT ); Tue, 24 Jan 2012 19:33:25 -0500 Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 585722123C for ; Tue, 24 Jan 2012 19:33:25 -0500 (EST) Date: Tue, 24 Jan 2012 16:33:13 -0800 From: Greg KH To: Alan Stern Cc: Jesse Barnes , Dominik Brodowski , linux-pci@vger.kernel.org, linux-pcmcia@lists.infradead.org, USB list Subject: Re: [PATCH resend] Clean up new_id and remove_id sysfs attribute routines Message-ID: <20120125003313.GA15617@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Jan 24, 2012 at 02:35:13PM -0500, Alan Stern wrote: > This patch (as1514) cleans up some places where new_id and remove_id > sysfs attributes are created and deleted. Handling both attributes in > a single routine rather than a pair of routines makes the code > smaller. It also prevents certain kinds of errors, like one we > currently have in the USB subsystem: The removeid attribute is often > created even when newid isn't (because the driver's no_dynamid_id flag > is set). > > In the case of the PCMCIA subsystem, the newid attribute is created > but never explicitly deleted. The patch adds a deletion routine. > > Signed-off-by: Alan Stern > CC: Jesse Barnes > CC: Dominik Brodowski Jesse and Dominik, any objection for me to take this through my tree? thanks, greg k-h