From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from isilmar-3.linta.de ([188.40.101.200]:40879 "EHLO linta.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751120Ab2AYT4H (ORCPT ); Wed, 25 Jan 2012 14:56:07 -0500 Date: Wed, 25 Jan 2012 20:33:46 +0100 From: Dominik Brodowski To: Alan Stern Cc: Greg KH , linux-input@vger.kernel.org, linux-pcmcia@lists.infradead.org, Jiri Kosina , Dmitry Torokhov , Kernel development list , USB list , Jesse Barnes , linux-pci@vger.kernel.org Subject: Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver() Message-ID: <20120125193346.GB9192@comet.dominikbrodowski.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Jan 24, 2012 at 01:34:41PM -0500, Alan Stern wrote: > As part of the removal of get_driver()/put_driver(), this patch > (as1511) changes all the places that add dynamic IDs for drivers. > Since these additions are done by writing to the drivers' sysfs > attribute files, and the attributes are removed when the drivers are > unregistered, there is no reason to take an extra reference to the > drivers. > > The one exception is the pci-stub driver, which calls pci_add_dynid() > as part of its registration. But again, there's no reason to take an > extra reference here, because the driver can't be unloaded while it is > being registered. > > Signed-off-by: Alan Stern > CC: Dmitry Torokhov > CC: Jiri Kosina > CC: Jesse Barnes > CC: Dominik Brodowski For the PCMCIA part: Acked-by: Dominik Brodowski Thanks, Dominik