From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from oproxy9.bluehost.com ([69.89.24.6]:47739 "HELO oproxy9.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751648Ab2A0RhB (ORCPT ); Fri, 27 Jan 2012 12:37:01 -0500 Date: Fri, 27 Jan 2012 09:36:58 -0800 From: Jesse Barnes To: Benjamin Herrenschmidt Cc: linux-pci@vger.kernel.org, Linux Kernel list Subject: Re: Probing unconfigured PCI bridge resouces Message-ID: <20120127093658.27dc258b@jbarnes-desktop> In-Reply-To: <1327380633.19850.33.camel@pasglop> References: <1327379147.19850.29.camel@pasglop> <1327380633.19850.33.camel@pasglop> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/0C_LC6pRRQm5+i5lV0X9G.3"; protocol="application/pgp-signature" Sender: linux-pci-owner@vger.kernel.org List-ID: --Sig_/0C_LC6pRRQm5+i5lV0X9G.3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 24 Jan 2012 15:50:33 +1100 Benjamin Herrenschmidt wrote: > On Tue, 2012-01-24 at 15:25 +1100, Benjamin Herrenschmidt wrote: > .../... >=20 > > Or am I missing some important fact here ? >=20 > Ok, I think I was missing pci_bridge_check_ranges(), gotta figure now > why this didn't kick in properly for me, probably some arch code > crackpot. >=20 > One thing I noticed is that we do clear IORESOURCE_UNSET in setup-res.c > when setting up a device resource but we don't clear it for bridges in > generic code ever, so it leaks all the way through from my early arch > code. Not a big deal but annoying. Maybe you can fix that when you unify your arch resource handling code with the core one day. :) There have been a lot of changes to handle re-allocation and such, and I'm sure there's more duplication now... --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/0C_LC6pRRQm5+i5lV0X9G.3 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJPIuC7AAoJEIEoDkX4Qk9h4S0QAL8t4l+FI69paZz8x9eQBemo o2D6aI+mgA+hOA8NE/11+1PuETJdut0HYwniYeKTmwtCmgg5LtexmmpWvbSEnke1 oM4kazeuKjdheT1t7B6mjSqshzWS+t4f0PtCHMWhPfnM1Ia+eKuwIV7N6t6IsvfE 7s/dD4jBoDgwpEVHmO+23zVT7oxQ2BEpEH265pd2DKdZfoEW6VJSnyDheBqMHuC/ 6hCCt+ItE8suVndFp+4+4cryo1KVfCbdJITK66sBeh0QQYQ1fuCJzNZS3wFyiOjG VHt8V+s5J9k6zn/B4C8lQEOniX2U8nmHujpsh0rosU8DTQZop2l7fEe1qgbnRjOK p7KF7biN88JvL+LXX0Zi7jUa1RluAAAIN/WF3hxNLLyCYNP6DHXobVEyQ++ZlTqa iSfnvPyHQeOFNOGMFOy9VOCRwXAnGJL5vCqs/HoAAeUcW4Ue1BRz29tGnniO+Ce8 B7192+fVMfhIOAZBbvsaphuwIC2UYXOxiq3ZT6cGfTV29oct7Jc1D77o/Z5mS23i yrdwXRtulB7q6EPaxSGDFBWOp/AARyLBcrUG0hNmQFXbi0pXCP+nIC+2QZwi5ERH zyWwlbywpxsCLX9WD9CEH8iz9JoY1DJpwsI1kW+T9LMI/HDV0jnrSKyDJlPTp5ro PIqir2rYEcyAbIcIAjGw =8vZJ -----END PGP SIGNATURE----- --Sig_/0C_LC6pRRQm5+i5lV0X9G.3--