* [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs
@ 2012-01-24 0:46 Seth Heasley
2012-01-24 1:14 ` Greg KH
2012-01-27 18:31 ` Jesse Barnes
0 siblings, 2 replies; 4+ messages in thread
From: Seth Heasley @ 2012-01-24 0:46 UTC (permalink / raw)
To: jbarnes, linux-pci; +Cc: linux-kernel, james.d.ralston, seth.heasley
This patch adds the LPC Controller DeviceIDs for the Intel Lynx Point PCH.
Signed-off-by: Seth Heasley <seth.heasley@intel.com>
---
arch/x86/pci/irq.c | 4 +++-
include/linux/pci_ids.h | 2 ++
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c
index 372e9b8..22468b6 100644
--- a/arch/x86/pci/irq.c
+++ b/arch/x86/pci/irq.c
@@ -604,7 +604,9 @@ static __init int intel_router_probe(struct irq_router *r, struct pci_dev *route
|| (device >= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN &&
device <= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX)
|| (device >= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN &&
- device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)) {
+ device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)
+ || (device >= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN &&
+ device <= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX)) {
r->name = "PIIX/ICH";
r->get = pirq_piix_get;
r->set = pirq_piix_set;
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 31d77af..6a0359a 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2800,6 +2800,8 @@
#define PCI_DEVICE_ID_INTEL_82454NX 0x84cb
#define PCI_DEVICE_ID_INTEL_84460GX 0x84ea
#define PCI_DEVICE_ID_INTEL_IXP4XX 0x8500
+#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN 0x8c40
+#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX 0x8c5f
#define PCI_DEVICE_ID_INTEL_IXP2800 0x9004
#define PCI_DEVICE_ID_INTEL_S21152BB 0xb152
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs
2012-01-24 0:46 [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs Seth Heasley
@ 2012-01-24 1:14 ` Greg KH
2012-01-27 18:31 ` Jesse Barnes
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2012-01-24 1:14 UTC (permalink / raw)
To: Seth Heasley; +Cc: jbarnes, linux-pci, linux-kernel, james.d.ralston
On Mon, Jan 23, 2012 at 04:46:24PM -0800, Seth Heasley wrote:
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2800,6 +2800,8 @@
> #define PCI_DEVICE_ID_INTEL_82454NX 0x84cb
> #define PCI_DEVICE_ID_INTEL_84460GX 0x84ea
> #define PCI_DEVICE_ID_INTEL_IXP4XX 0x8500
> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN 0x8c40
> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX 0x8c5f
You forgot to read the top of this file.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs
2012-01-24 0:46 [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs Seth Heasley
2012-01-24 1:14 ` Greg KH
@ 2012-01-27 18:31 ` Jesse Barnes
2012-01-27 18:56 ` Heasley, Seth
1 sibling, 1 reply; 4+ messages in thread
From: Jesse Barnes @ 2012-01-27 18:31 UTC (permalink / raw)
To: Seth Heasley; +Cc: linux-pci, linux-kernel, james.d.ralston
[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]
On Mon, 23 Jan 2012 16:46:24 -0800
Seth Heasley <seth.heasley@intel.com> wrote:
> This patch adds the LPC Controller DeviceIDs for the Intel Lynx Point PCH.
>
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
> ---
> arch/x86/pci/irq.c | 4 +++-
> include/linux/pci_ids.h | 2 ++
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c
> index 372e9b8..22468b6 100644
> --- a/arch/x86/pci/irq.c
> +++ b/arch/x86/pci/irq.c
> @@ -604,7 +604,9 @@ static __init int intel_router_probe(struct irq_router *r, struct pci_dev *route
> || (device >= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN &&
> device <= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX)
> || (device >= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN &&
> - device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)) {
> + device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)
> + || (device >= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN &&
> + device <= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX)) {
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 31d77af..6a0359a 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2800,6 +2800,8 @@
> #define PCI_DEVICE_ID_INTEL_82454NX 0x84cb
> #define PCI_DEVICE_ID_INTEL_84460GX 0x84ea
> #define PCI_DEVICE_ID_INTEL_IXP4XX 0x8500
> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN 0x8c40
> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX 0x8c5f
> #define PCI_DEVICE_ID_INTEL_IXP2800 0x9004
> #define PCI_DEVICE_ID_INTEL_S21152BB 0xb152
>
Seems we add every new GMCH or PCH anyway, why not just use the piix
routines for any unknown (therefore presumably new) Intel PCH device?
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs
2012-01-27 18:31 ` Jesse Barnes
@ 2012-01-27 18:56 ` Heasley, Seth
0 siblings, 0 replies; 4+ messages in thread
From: Heasley, Seth @ 2012-01-27 18:56 UTC (permalink / raw)
To: Jesse Barnes
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Ralston, James D
>> This patch adds the LPC Controller DeviceIDs for the Intel Lynx Point
>PCH.
>>
>> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
>> ---
>> arch/x86/pci/irq.c | 4 +++-
>> include/linux/pci_ids.h | 2 ++
>> 2 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c index
>> 372e9b8..22468b6 100644
>> --- a/arch/x86/pci/irq.c
>> +++ b/arch/x86/pci/irq.c
>> @@ -604,7 +604,9 @@ static __init int intel_router_probe(struct
>irq_router *r, struct pci_dev *route
>> || (device >= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN &&
>> device <= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX)
>> || (device >= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN &&
>> - device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)) {
>> + device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)
>> + || (device >= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN &&
>> + device <= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX)) {
>> r->name = "PIIX/ICH";
>> r->get = pirq_piix_get;
>> r->set = pirq_piix_set;
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index
>> 31d77af..6a0359a 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2800,6 +2800,8 @@
>> #define PCI_DEVICE_ID_INTEL_82454NX 0x84cb
>> #define PCI_DEVICE_ID_INTEL_84460GX 0x84ea
>> #define PCI_DEVICE_ID_INTEL_IXP4XX 0x8500
>> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN 0x8c40
>> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX 0x8c5f
>> #define PCI_DEVICE_ID_INTEL_IXP2800 0x9004
>> #define PCI_DEVICE_ID_INTEL_S21152BB 0xb152
>>
>
>Seems we add every new GMCH or PCH anyway, why not just use the piix
>routines for any unknown (therefore presumably new) Intel PCH device?
Makes sense to me.
-Seth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-27 18:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 0:46 [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs Seth Heasley
2012-01-24 1:14 ` Greg KH
2012-01-27 18:31 ` Jesse Barnes
2012-01-27 18:56 ` Heasley, Seth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).