From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com
Subject: Re: [PATCH 1/2] pci: Introduce __pci_reset_function_locked to be used when holding device_lock.
Date: Fri, 27 Jan 2012 14:07:22 -0500 [thread overview]
Message-ID: <20120127190722.GA14256@phenom.dumpdata.com> (raw)
In-Reply-To: <20120127093225.7c1194ae@jbarnes-desktop>
On Fri, Jan 27, 2012 at 09:32:25AM -0800, Jesse Barnes wrote:
> On Thu, 12 Jan 2012 12:06:46 -0500
> Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>
> > The use case of this is when a driver wants to call FLR when a device
> > is attached to it using the SysFS "bind" or "unbind" functionality.
> >
> > The call chain when a user does "bind" looks as so:
> >
> > echo "0000:01.07.0" > /sys/bus/pci/drivers/XXXX/bind
> >
> > and ends up calling:
> > driver_bind:
> > device_lock(dev); <=== TAKES LOCK
> > XXXX_probe:
> > .. pci_enable_device()
> > ...__pci_reset_function(), which calls
> > pci_dev_reset(dev, 0):
> > if (!0) {
> > device_lock(dev) <==== DEADLOCK
>
> I have these two in my -next branch now; but you could also push them
> through the Xen tree. If you have other deps and the Xen tree would be
> easier, just let me know and I'll drop them.
Thanks! Lets keep them in your tree.
next prev parent reply other threads:[~2012-01-27 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:06 [PATCH] xen-pciback features for v3.4 (FLR). v2 Konrad Rzeszutek Wilk
2012-01-12 17:06 ` [PATCH 1/2] pci: Introduce __pci_reset_function_locked to be used when holding device_lock Konrad Rzeszutek Wilk
2012-01-27 17:32 ` Jesse Barnes
2012-01-27 19:07 ` Konrad Rzeszutek Wilk [this message]
2012-01-12 17:06 ` [PATCH 2/2] xen/pciback: Support pci_reset_function, aka FLR or D3 support Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127190722.GA14256@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).