From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jan 2012 11:42:50 +0900 From: Yoichi Yuasa To: Bjorn Helgaas Cc: yuasa@linux-mips.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Ralf Baechle Subject: Re: [RFC PATCH v1 11/18] mips/PCI: get rid of device resource fixups Message-Id: <20120131114250.b0e6af10.yuasa@linux-mips.org> In-Reply-To: <20120130165805.3231.99160.stgit@bhelgaas.mtv.corp.google.com> References: <20120130165430.3231.97740.stgit@bhelgaas.mtv.corp.google.com> <20120130165805.3231.99160.stgit@bhelgaas.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: Hi, On Mon, 30 Jan 2012 09:58:05 -0700 Bjorn Helgaas wrote: > Tell the PCI core about host bridge address translation so it can take > care of bus-to-resource conversion for us. > > N.B. cobalt_legacy_ide_fixup() does scary things with resources, but I > *think* it will still work because we're still making the same adjustments, > just in the opposite order. Here are the legacy IDE resource.start > values I expect: > > current new > > 0x1f0 (pci_setup_device) 0x1f0 > (pci_bus_to_resource) + 0xf0000000 > - 0xf0000000 (cobalt_legacy_ide_fixup) - 0xf0000000 > + 0xf0000000 (pcibios_fixup_bus) > ------------ ------------ > 0x1f0 final value 0x1f0 It seems to be unable to handle the offset correctly. failed on Cobalt: pata_via 0000:00:09.1: BAR 0: can't reserve [io 0x100001f0-0x100001f7] pata_via 0000:00:09.1: failed to request/iomap BARs for port 0 (errno=-16) pata_via 0000:00:09.1: BAR 2: can't reserve [io 0x10000170-0x10000177] pata_via 0000:00:09.1: failed to request/iomap BARs for port 1 (errno=-16) pata_via 0000:00:09.1: no available native port Yoichi