From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from isilmar-3.linta.de ([188.40.101.200]:38824 "EHLO linta.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752439Ab2BEV6f (ORCPT ); Sun, 5 Feb 2012 16:58:35 -0500 Date: Sun, 5 Feb 2012 22:58:24 +0100 From: Dominik Brodowski To: Yinghai Lu Cc: Jesse Barnes , Ram Pai , Linus Torvalds , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional size handling Message-ID: <20120205215824.GA5071@comet.dominikbrodowski.net> References: <1327140517-14811-1-git-send-email-yinghai@kernel.org> <1327140517-14811-19-git-send-email-yinghai@kernel.org> <20120127102311.6027ea2c@jbarnes-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Jan 27, 2012 at 01:37:44PM -0800, Yinghai Lu wrote: > On Fri, Jan 27, 2012 at 10:23 AM, Jesse Barnes wrote: > > On Sat, 21 Jan 2012 02:08:34 -0800 > > Yinghai Lu wrote: > > > >> We should not set the requested size to -2. > >> > >> that will confuse the resource list sorting with align when SIZEALIGN is used. > >> > >> Change to STARTALIGN and pass align from start. > >> > >> We are safe to do that just as we do that regular pci bridge. > >> > >> In the long run, we should just treat cardbus like regular pci bridge. > >> > >> Also fix when realloc is not passed, should keep the requested size. > >> > >> Signed-off-by: Yinghai Lu > > > > I'd like to see some testing on this one... Dominik? > > Dominik, > > Can you please test branch at > > git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git > for-pci2 Tested this on my limited test systems (COUNT=1), and seems to work fine. Best, Dominik