From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: Scott Murray <scott@spiteful.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/16] cpcihp: fix debug module parameter to be bool
Date: Fri, 10 Feb 2012 11:40:45 -0800 [thread overview]
Message-ID: <20120210114045.08a2d313@jbarnes-desktop> (raw)
In-Reply-To: <1327960820-11867-7-git-send-email-danny.kukawka@bisect.de>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Mon, 30 Jan 2012 23:00:10 +0100
Danny Kukawka <danny.kukawka@bisect.de> wrote:
> Fix debug variable from module parameter to be really bool to
> fix 'warning: return from incompatible pointer type'.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
> ---
> drivers/pci/hotplug/cpcihp_generic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpcihp_generic.c b/drivers/pci/hotplug/cpcihp_generic.c
> index fb3f846..81af764 100644
> --- a/drivers/pci/hotplug/cpcihp_generic.c
> +++ b/drivers/pci/hotplug/cpcihp_generic.c
> @@ -62,7 +62,7 @@
> #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg)
>
> /* local variables */
> -static int debug;
> +static bool debug;
> static char *bridge;
> static u8 bridge_busnr;
> static u8 bridge_slot;
Applied to my -next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-10 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1327960820-11867-1-git-send-email-danny.kukawka@bisect.de>
2012-01-30 22:00 ` [PATCH 06/16] cpcihp: fix debug module parameter to be bool Danny Kukawka
2012-02-03 0:06 ` Scott Murray
2012-02-10 19:40 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210114045.08a2d313@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=danny.kukawka@bisect.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).