From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ram Pai <linuxram@us.ibm.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] PCI: Fix cardbus bridge resources as optional size handling
Date: Fri, 10 Feb 2012 12:52:58 -0800 [thread overview]
Message-ID: <20120210125258.55c1f339@jbarnes-desktop> (raw)
In-Reply-To: <CAE9FiQUYg8V8RSeh+xiWYxEfSxwEhp9KRXAjVkyhT94Enkqc3Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]
On Tue, 7 Feb 2012 22:11:22 -0800
Yinghai Lu <yinghai@kernel.org> wrote:
> On Tue, Feb 7, 2012 at 9:01 PM, Ram Pai <linuxram@us.ibm.com> wrote:
> >
> > ..snip..
> >> * If we have prefetchable memory support, allocate
> >> * two regions. Otherwise, allocate one region of
> >> * twice the size.
> >> */
> >> if (ctrl & PCI_CB_BRIDGE_CTL_PREFETCH_MEM0) {
> >> b_res[2].start = pci_cardbus_mem_size;
> >> b_res[2].end = b_res[2].start + pci_cardbus_mem_size - 1;
> >> b_res[2].flags |= IORESOURCE_MEM | IORESOURCE_PREFETCH |
> >> IORESOURCE_STARTALIGN;
> >> if (realloc_head) {
> >> b_res[2].end -= pci_cardbus_mem_size;
> >> add_to_list(realloc_head, bridge, b_res+2,
> >> pci_cardbus_mem_size, pci_cardbus_mem_size);
> >> }
> >>
> >> /* reduce that to half */
> >> b_res_3_size = pci_cardbus_mem_size;
> >> }
> >
> > ACK. Ok. got it. This looks correct.
>
> Good, So we have
>
> Acked-by: Ram Pai <linuxram@us.ibm.com>
> Tested-by: Dominik Brodowski <linux@dominikbrodowski.net>
>
> Hope Jesse will not miss to add them
Yeah looks fine. I'd like to see an ack from Dominik on 5/9 as well
though. Can you include the acks and tested-bys when you re-post 3-9
with bug references and any other comments included?
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-10 20:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 6:54 [PATCH -v2 0/9] PCI : bridge resource reallocation patchset -- followup Yinghai Lu
2012-02-05 6:55 ` [PATCH 1/9] pci: Fix pci cardbus removal Yinghai Lu
2012-02-10 20:20 ` Jesse Barnes
2012-02-05 6:55 ` [PATCH 2/9] PCI: Fix /sys warning when sriov enabled card is hot removed Yinghai Lu
2012-02-10 20:39 ` Jesse Barnes
2012-02-05 6:55 ` [PATCH 3/9] PCI: Disable cardbus bridge MEM1 pref CTL Yinghai Lu
2012-02-10 20:46 ` Jesse Barnes
2012-02-10 20:54 ` Yinghai Lu
2012-02-10 22:11 ` Bjorn Helgaas
2012-02-05 6:55 ` [PATCH 4/9] PCI: Fix cardbus bridge resources as optional size handling Yinghai Lu
2012-02-08 4:35 ` Ram Pai
2012-02-08 4:48 ` Yinghai Lu
2012-02-08 5:01 ` Ram Pai
2012-02-08 6:11 ` Yinghai Lu
2012-02-10 20:52 ` Jesse Barnes [this message]
2012-02-10 20:56 ` Yinghai Lu
2012-02-05 6:55 ` [PATCH 5/9] PCI: Skip reset cardbus assigned resource during pci bus rescan Yinghai Lu
2012-02-05 6:55 ` [PATCH 6/9] PCI: Retry on type IORESOURCE_IO allocation Yinghai Lu
2012-02-05 6:55 ` [PATCH 7/9] PCI: Make pci bridge reallocating enabled/disabled Yinghai Lu
2012-02-10 20:56 ` Jesse Barnes
2012-02-05 6:55 ` [PATCH 8/9] PCI: print out suggestion about using pci=realloc Yinghai Lu
2012-02-10 20:59 ` Jesse Barnes
2012-02-05 6:55 ` [PATCH 9/9] PCI: only enable pci realloc when SRIOV bar is not assigned Yinghai Lu
2012-02-10 21:00 ` Jesse Barnes
2012-02-10 21:23 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210125258.55c1f339@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxram@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).