From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: fix memleak when ACPI _CRS is not used.
Date: Thu, 23 Feb 2012 08:27:03 -0800 [thread overview]
Message-ID: <20120223082703.5d87dab4@jbarnes-desktop> (raw)
In-Reply-To: <1329787427-17890-1-git-send-email-yinghai@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
On Mon, 20 Feb 2012 17:23:47 -0800
Yinghai Lu <yinghai@kernel.org> wrote:
> got warning:
> unreferenced object 0xffff8801f6914200 (size 512):
> comm "swapper/0", pid 1, jiffies 4294893643 (age 2664.644s)
> hex dump (first 32 bytes):
> 00 00 c0 fe 00 00 00 00 ff ff ff ff 00 00 00 00 ................
> 60 58 2f f6 03 88 ff ff 00 02 00 00 00 00 00 00 `X/.............
> backtrace:
> [<ffffffff81c2408c>] kmemleak_alloc+0x26/0x43
> [<ffffffff8113764f>] __kmalloc+0x121/0x183
> [<ffffffff81ca8d93>] get_current_resources+0x5a/0xc6
> [<ffffffff81c5bedd>] pci_acpi_scan_root+0x13c/0x21c
> [<ffffffff81c2a745>] acpi_pci_root_add+0x1e1/0x421
> [<ffffffff81408f50>] acpi_device_probe+0x50/0x190
> [<ffffffff8149edc7>] really_probe+0x99/0x126
> [<ffffffff8149ef83>] driver_probe_device+0x3b/0x56
> [<ffffffff8149effd>] __driver_attach+0x5f/0x82
> [<ffffffff8149d860>] bus_for_each_dev+0x5c/0x88
> [<ffffffff8149eb87>] driver_attach+0x1e/0x20
> [<ffffffff8149e7cc>] bus_add_driver+0xca/0x21d
> [<ffffffff8149f47b>] driver_register+0x91/0xfe
> [<ffffffff81409d09>] acpi_bus_register_driver+0x43/0x45
> [<ffffffff8278bdc9>] acpi_pci_root_init+0x20/0x28
> [<ffffffff810001e7>] do_one_initcall+0x57/0x134
>
> The system have _CRS for root buses, but they are not used because is old...
>
> Try free those not used resource array and name.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Applied to for-linus, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-23 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 1:23 [PATCH] PCI: fix memleak when ACPI _CRS is not used Yinghai Lu
2012-02-22 20:40 ` Bjorn Helgaas
2012-02-23 16:27 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223082703.5d87dab4@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).