Re: [andreas.herrmann3@amd.com: [PATCH 1/2] x86/amd: Restore early_fill_mp_bus_to_node]

[Jesse Barnes <jbarnes@virtuousgeek.org>]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

On Mon, 27 Feb 2012 10:44:06 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> 
> Yours?
> 
> ----- Forwarded message from Andreas Herrmann <andreas.herrmann3@amd.com> -----
> 
> Date: Fri, 24 Feb 2012 16:19:12 +0100
> From: Andreas Herrmann <andreas.herrmann3@amd.com>
> To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin"
> 	<hpa@zytor.com>
> CC: linux-kernel@vger.kernel.org
> Subject: [PATCH 1/2] x86/amd: Restore early_fill_mp_bus_to_node
> 
> 
> Once upon a time this function was overloaded with quirky stuff to fix
> resource detection on systems w/ _CRS defects (seems that some Sun and
> HP systems were affected).
> 
> See commit 30a18d6c3f1e774de656ebd8ff219d53e2ba4029
> (x86: multi pci root bus with different io resource range, on 64-bit)
> 
> Restore the old function and thus decouple it from the quirk that is
> CPU family specific (e.g. it won't work on AMD family 15h CPUs). BTW,
> I assume that the _CRS stuff is working on current systems.
> 
> This is required to properly initilize the numa_node information of
> PCI busses and associated devices.
> 
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
>  arch/x86/pci/amd_bus.c |   84 +++++++++++++++++++++++++++++++----------------

ISTR this function getting things wrong on some Nehalem based systems,
and assigning all IO devices to node 0, resulting in bad NIC
performance.

Jesse, are things working ok now?  Care to test this patch to make sure
it doesn't regress anything on one of the previously affected systems?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]